Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go devcontainer image to version 1.23 #39526

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

obounaim
Copy link
Contributor

Description

I would like to request an upgrade of the Go version used in the VSCode devcontainer.

Current Go Version: 1.22
Proposed Go Version: 1.23

Relations

Closes #39525

@obounaim obounaim requested a review from a team as a code owner September 28, 2024 08:52
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 28, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit ewbankkit added go Pull requests that update Go code and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 30, 2024
@ewbankkit
Copy link
Contributor

@obounaim Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ad3a8be into hashicorp:main Sep 30, 2024
18 checks passed
@github-actions github-actions bot added this to the v5.70.0 milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Repo]: Upgrade Go version in VSCode Dev Container
2 participants