Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_lambda_event_source_mapping & resource/aws_lambda_code_signing_config: Add tags support #39535

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

trutled3
Copy link
Contributor

Description

This pull request adds support for managing tags on both the aws_lambda_event_source_mapping and aws_lambda_code_signing_config resources. This was recently added to the associated AWS APIs on Sept 23, 2024.

Relations

Closes #39468

References

Output from Acceptance Testing

% TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaCodeSigningConfig_Tags' -timeout 360m
=== RUN   TestAccLambdaCodeSigningConfig_Tags
=== PAUSE TestAccLambdaCodeSigningConfig_Tags
=== CONT  TestAccLambdaCodeSigningConfig_Tags
--- PASS: TestAccLambdaCodeSigningConfig_Tags (13.96s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lambda     19.070s

% TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaEventSourceMapping_Tags' -timeout 360m
=== RUN   TestAccLambdaEventSourceMapping_Tags
=== PAUSE TestAccLambdaEventSourceMapping_Tags
=== CONT  TestAccLambdaEventSourceMapping_Tags
--- PASS: TestAccLambdaEventSourceMapping_Tags (46.38s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lambda     51.508s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lambda Issues and PRs that pertain to the lambda service. service/emr Issues and PRs that pertain to the emr service. needs-triage Waiting for first response or review from a maintainer. labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. service/emr Issues and PRs that pertain to the emr service. service/lambda Issues and PRs that pertain to the lambda service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lambda now supports tagging of Event Source Mappings and Code Signing Config resources
1 participant