Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_iam_group_policies_exclusive: new resource #39554

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Oct 1, 2024

Description

This resource will enable exclusive management of inline policy assignments to an IAM group via Terraform.

Relations

Relates #39376
Closes #39378

References

Output from Acceptance Testing

% make testacc PKG=iam TESTS=TestAccIAMGroupPoliciesExclusive_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMGroupPoliciesExclusive_'  -timeout 360m

--- PASS: TestAccIAMGroupPoliciesExclusive_disappears_Group (15.36s)
--- PASS: TestAccIAMGroupPoliciesExclusive_empty (15.37s)
--- PASS: TestAccIAMGroupPoliciesExclusive_basic (17.31s)
--- PASS: TestAccIAMGroupPoliciesExclusive_outOfBandAddition (23.80s)
--- PASS: TestAccIAMGroupPoliciesExclusive_outOfBandRemoval (23.85s)
--- PASS: TestAccIAMGroupPoliciesExclusive_multiple (25.71s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iam        31.049s

Copy link

github-actions bot commented Oct 1, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/iam Issues and PRs that pertain to the iam service. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Oct 1, 2024
@jar-b jar-b force-pushed the f-iam_group_policies_exclusive branch from c7e55e8 to 1773315 Compare October 1, 2024 16:19
This resource will enable exclusive management of IAM group policy attachments via Terraform.

```console
% make testacc PKG=iam TESTS=TestAccIAMGroupPoliciesExclusive_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMGroupPoliciesExclusive_'  -timeout 360m

--- PASS: TestAccIAMGroupPoliciesExclusive_disappears_Group (15.36s)
--- PASS: TestAccIAMGroupPoliciesExclusive_empty (15.37s)
--- PASS: TestAccIAMGroupPoliciesExclusive_basic (17.31s)
--- PASS: TestAccIAMGroupPoliciesExclusive_outOfBandAddition (23.80s)
--- PASS: TestAccIAMGroupPoliciesExclusive_outOfBandRemoval (23.85s)
--- PASS: TestAccIAMGroupPoliciesExclusive_multiple (25.71s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iam        31.049s
```
@jar-b jar-b force-pushed the f-iam_group_policies_exclusive branch from 1773315 to 7ab7cde Compare October 1, 2024 16:24
@jar-b jar-b marked this pull request as ready for review October 1, 2024 17:29
@jar-b jar-b requested a review from a team as a code owner October 1, 2024 17:29
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccIAMGroupPoliciesExclusive_' PKG=iam ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/iam/... -v -count 1 -parallel 3  -run=TestAccIAMGroupPoliciesExclusive_ -timeout 360m
=== RUN   TestAccIAMGroupPoliciesExclusive_basic
=== PAUSE TestAccIAMGroupPoliciesExclusive_basic
=== RUN   TestAccIAMGroupPoliciesExclusive_disappears_Group
=== PAUSE TestAccIAMGroupPoliciesExclusive_disappears_Group
=== RUN   TestAccIAMGroupPoliciesExclusive_multiple
=== PAUSE TestAccIAMGroupPoliciesExclusive_multiple
=== RUN   TestAccIAMGroupPoliciesExclusive_empty
=== PAUSE TestAccIAMGroupPoliciesExclusive_empty
=== RUN   TestAccIAMGroupPoliciesExclusive_outOfBandRemoval
=== PAUSE TestAccIAMGroupPoliciesExclusive_outOfBandRemoval
=== RUN   TestAccIAMGroupPoliciesExclusive_outOfBandAddition
=== PAUSE TestAccIAMGroupPoliciesExclusive_outOfBandAddition
=== CONT  TestAccIAMGroupPoliciesExclusive_basic
=== CONT  TestAccIAMGroupPoliciesExclusive_empty
=== CONT  TestAccIAMGroupPoliciesExclusive_outOfBandAddition
--- PASS: TestAccIAMGroupPoliciesExclusive_empty (11.09s)
=== CONT  TestAccIAMGroupPoliciesExclusive_multiple
--- PASS: TestAccIAMGroupPoliciesExclusive_basic (12.87s)
=== CONT  TestAccIAMGroupPoliciesExclusive_outOfBandRemoval
--- PASS: TestAccIAMGroupPoliciesExclusive_outOfBandAddition (18.19s)
=== CONT  TestAccIAMGroupPoliciesExclusive_disappears_Group
--- PASS: TestAccIAMGroupPoliciesExclusive_disappears_Group (10.70s)
--- PASS: TestAccIAMGroupPoliciesExclusive_multiple (18.99s)
--- PASS: TestAccIAMGroupPoliciesExclusive_outOfBandRemoval (17.21s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	35.658s

@jar-b jar-b merged commit 366b4fb into main Oct 2, 2024
48 checks passed
@jar-b jar-b deleted the f-iam_group_policies_exclusive branch October 2, 2024 13:01
@github-actions github-actions bot added this to the v5.70.0 milestone Oct 2, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Oct 2, 2024
Copy link

github-actions bot commented Oct 4, 2024

This functionality has been released in v5.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: aws_iam_group_policies_exclusive
2 participants