-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider: Converts conns.AWSClient
IgnoreTagsConfig
to function and adds transparent tagging to several data sources
#39761
Conversation
Community NoteVoting for Prioritization
For Submitters
|
bed2f40
to
3d507ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccBudgetsBudgetDataSource_' PKG=budgets
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/budgets/... -v -count 1 -parallel 20 -run=TestAccBudgetsBudgetDataSource_ -timeout 360m
2024/10/17 08:16:01 Initializing Terraform AWS Provider...
=== RUN TestAccBudgetsBudgetDataSource_tags
=== PAUSE TestAccBudgetsBudgetDataSource_tags
=== RUN TestAccBudgetsBudgetDataSource_tags_NullMap
=== PAUSE TestAccBudgetsBudgetDataSource_tags_NullMap
=== RUN TestAccBudgetsBudgetDataSource_tags_EmptyMap
=== PAUSE TestAccBudgetsBudgetDataSource_tags_EmptyMap
=== RUN TestAccBudgetsBudgetDataSource_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccBudgetsBudgetDataSource_tags_DefaultTags_nonOverlapping
=== RUN TestAccBudgetsBudgetDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccBudgetsBudgetDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== RUN TestAccBudgetsBudgetDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccBudgetsBudgetDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== RUN TestAccBudgetsBudgetDataSource_basic
=== PAUSE TestAccBudgetsBudgetDataSource_basic
=== CONT TestAccBudgetsBudgetDataSource_tags
=== CONT TestAccBudgetsBudgetDataSource_tags_EmptyMap
=== CONT TestAccBudgetsBudgetDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== CONT TestAccBudgetsBudgetDataSource_tags_DefaultTags_nonOverlapping
=== CONT TestAccBudgetsBudgetDataSource_basic
=== CONT TestAccBudgetsBudgetDataSource_tags_NullMap
=== CONT TestAccBudgetsBudgetDataSource_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccBudgetsBudgetDataSource_tags_NullMap (22.06s)
--- PASS: TestAccBudgetsBudgetDataSource_tags_EmptyMap (22.21s)
--- PASS: TestAccBudgetsBudgetDataSource_tags_DefaultTags_nonOverlapping (22.22s)
--- PASS: TestAccBudgetsBudgetDataSource_tags (22.25s)
--- PASS: TestAccBudgetsBudgetDataSource_tags_IgnoreTags_Overlap_DefaultTag (22.34s)
--- PASS: TestAccBudgetsBudgetDataSource_tags_IgnoreTags_Overlap_ResourceTag (22.98s)
--- PASS: TestAccBudgetsBudgetDataSource_basic (37.36s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/budgets 42.691s
This functionality has been released in v5.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Converts
conns.AWSClient
IgnoreTagsConfig
to function and adds transparent tagging to several data sources. Adds tagging tests as needed