r/sagemaker_feature_group - add support for feature_definition.collection_config, feature_definition.collection_type, and throughput_config

[DrFaust92]

Description

Relations

Closes #0000

References

Output from Acceptance Testing

% make testacc TESTS=TestAccSageMakerFeatureGroup_  PKG=sagemaker 

--- PASS: TestAccSageMakerFeatureGroup_serial/featureDefinition_collectionType (1080.56s)
--- PASS: TestAccSageMakerFeatureGroup_serial/offlineConfig_basic (65.26s)
--- PASS: TestAccSageMakerFeatureGroup_serial/throughputConfig (90.76s)
--- PASS: TestAccSageMakerFeatureGroup_serial/featureDefinition_collectionConfig (987.91s)

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSageMakerFeatureGroup_serial' PKG=sagemaker
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/sagemaker/... -v -count 1 -parallel 20  -run=TestAccSageMakerFeatureGroup_serial -timeout 360m
2024/10/21 10:41:01 Initializing Terraform AWS Provider...
=== RUN   TestAccSageMakerFeatureGroup_serial
=== PAUSE TestAccSageMakerFeatureGroup_serial
=== CONT  TestAccSageMakerFeatureGroup_serial
=== RUN   TestAccSageMakerFeatureGroup_serial/onlineConfig_TTLDuration
=== RUN   TestAccSageMakerFeatureGroup_serial/offlineConfig_createCatalog
    feature_group_test.go:382: Step 1/2 error: Error running apply: exit status 1
        
        Error: waiting for SageMaker Feature Group (tf-acc-test-6652578570583612463) to create: unexpected state 'CreateFailed', wanted target 'Created'. last error: Insufficient Lake Formation permission(s) on SageMaker_FeatureStore (Service: Glue, Status Code: 400, Request ID: 155c6403-d7d6-4be2-8872-0612ac85d1fe)
        
          with aws_sagemaker_feature_group.test,
          on terraform_plugin_test.tf line 57, in resource "aws_sagemaker_feature_group" "test":
          57: resource "aws_sagemaker_feature_group" "test" {
        
=== RUN   TestAccSageMakerFeatureGroup_serial/tags
=== RUN   TestAccSageMakerFeatureGroup_serial/basic
=== RUN   TestAccSageMakerFeatureGroup_serial/featureDefinition_collectionType
=== RUN   TestAccSageMakerFeatureGroup_serial/offlineConfig_basic
=== RUN   TestAccSageMakerFeatureGroup_serial/offlineConfig_format
    feature_group_test.go:348: Step 1/2 error: Error running apply: exit status 1
        
        Error: waiting for SageMaker Feature Group (tf-acc-test-1197924043093754364) to create: unexpected state 'CreateFailed', wanted target 'Created'. last error: Insufficient Lake Formation permission(s) on SageMaker_FeatureStore (Service: Glue, Status Code: 400, Request ID: 9c97c340-7e8c-4b32-9c4c-c35b39e84cfe)
        
          with aws_sagemaker_feature_group.test,
          on terraform_plugin_test.tf line 57, in resource "aws_sagemaker_feature_group" "test":
          57: resource "aws_sagemaker_feature_group" "test" {
        
=== RUN   TestAccSageMakerFeatureGroup_serial/multipleFeatures
=== RUN   TestAccSageMakerFeatureGroup_serial/throughputConfig
=== RUN   TestAccSageMakerFeatureGroup_serial/storageType
=== RUN   TestAccSageMakerFeatureGroup_serial/featureDefinition_collectionConfig
=== RUN   TestAccSageMakerFeatureGroup_serial/description
=== RUN   TestAccSageMakerFeatureGroup_serial/disappears
=== RUN   TestAccSageMakerFeatureGroup_serial/offlineConfig_providedCatalog
=== RUN   TestAccSageMakerFeatureGroup_serial/onlineConfigSecurityConfig
--- FAIL: TestAccSageMakerFeatureGroup_serial (3534.56s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/onlineConfig_TTLDuration (50.11s)
    --- FAIL: TestAccSageMakerFeatureGroup_serial/offlineConfig_createCatalog (74.78s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/tags (58.75s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/basic (40.85s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/featureDefinition_collectionType (774.50s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/offlineConfig_basic (54.01s)
    --- FAIL: TestAccSageMakerFeatureGroup_serial/offlineConfig_format (93.66s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/multipleFeatures (51.10s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/throughputConfig (93.40s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/storageType (909.49s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/featureDefinition_collectionConfig (937.31s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/description (50.93s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/disappears (48.98s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/offlineConfig_providedCatalog (58.14s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/onlineConfigSecurityConfig (71.88s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	3539.832s
FAIL
make: *** [testacc] Error 1

Failures are unrelated to this change and are occurring in CI.

[ewbankkit]

@DrFaust92 Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!