Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New data source aws_lb_listener_rule #39865

Merged
merged 24 commits into from
Oct 24, 2024
Merged

New data source aws_lb_listener_rule #39865

merged 24 commits into from
Oct 24, 2024
+2,647 −115

Conversation

gdavison
Copy link
Contributor

Description

Adds new data source aws_lb_listener_rule

Relations

Closes #19584

Output from Acceptance Testing

% make testacc PKG=elbv2 TESTS=TestAccELBV2ListenerRuleDataSource_

--- PASS: TestAccELBV2ListenerRuleDataSource_actionRedirect (231.03s)
--- PASS: TestAccELBV2ListenerRuleDataSource_byARN (232.85s)
--- PASS: TestAccELBV2ListenerRuleDataSource_conditionQueryString (233.96s)
--- PASS: TestAccELBV2ListenerRuleDataSource_tags_EmptyMap (242.30s)
--- PASS: TestAccELBV2ListenerRuleDataSource_actionFixedResponse (243.21s)
--- PASS: TestAccELBV2ListenerRuleDataSource_tags_IgnoreTags_Overlap_DefaultTag (251.00s)
--- PASS: TestAccELBV2ListenerRuleDataSource_byListenerAndPriority (257.91s)
--- PASS: TestAccELBV2ListenerRuleDataSource_tags_IgnoreTags_Overlap_ResourceTag (258.82s)
--- PASS: TestAccELBV2ListenerRuleDataSource_actionAuthenticateOIDC (259.97s)
--- PASS: TestAccELBV2ListenerRuleDataSource_conditionHTTPHeader (262.15s)
--- PASS: TestAccELBV2ListenerRuleDataSource_actionForwardWeightedStickiness (268.43s)
--- PASS: TestAccELBV2ListenerRuleDataSource_tags_NullMap (276.10s)
--- PASS: TestAccELBV2ListenerRuleDataSource_tags (285.75s)
--- PASS: TestAccELBV2ListenerRuleDataSource_conditionHTTPRequestMethod (286.02s)
--- PASS: TestAccELBV2ListenerRuleDataSource_conditionHostHeader (295.11s)
--- PASS: TestAccELBV2ListenerRuleDataSource_conditionSourceIP (296.88s)
--- PASS: TestAccELBV2ListenerRuleDataSource_actionAuthenticateCognito (312.83s)
--- PASS: TestAccELBV2ListenerRuleDataSource_tags_DefaultTags_nonOverlapping (342.52s)
--- PASS: TestAccELBV2ListenerRuleDataSource_conditionPathPattern (350.24s)

@gdavison gdavison requested a review from a team as a code owner October 23, 2024 21:19
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/elbv2 Issues and PRs that pertain to the elbv2 service. provider Pertains to the provider itself, rather than any interaction with AWS. generators Relates to code generators. skaff Issues and pull requested related to the skaff tool prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Oct 23, 2024
@gdavison
Delays regex compilation until actually needed
379906d
@gdavison
Uses value of arn attribute instead of id
210aad4
@gdavison
Uses arn for Listener Rule transparent tagging
46122d7
@gdavison
Registers AutoFlex logger for data sources
2a93c91
@gdavison
Adds data source aws_lb_listener_rule
f1eb865
@gdavison
Factors out Condition known value check
21c89b8
@gdavison
Adds lookup by listener ARN and priority
b3d5190
@gdavison
Adds tests for Condition types
d8f249a
@gdavison
Adds missing attributes to resource authentication_cognito test
49fea4c
@gdavison
Factors out action sorting and replaces sort.Slices with `slices.So…
e0536da 
…rtFunc`
@gdavison
Adds tests for authenticate actions
29d84cc
@gdavison
Adds tests for remaining actions
28c5e81
@gdavison
Removes top-level target_group_arn from action in favour of `forw…
441e6e1 
…ard.target_group.arn` for consistency in all cases
@gdavison
Updates root-level validation
64daf22
@gdavison
Grammar fix
ff1768d
@gdavison
Converts priority attribute from string to int32
028927a
@gdavison
Documents aws_lb_listener_rule data source
92dfe94
@gdavison
Adds tagging tests
f2e53de
@gdavison
skaff: Separates provider service package and sdk service package
7b059ad
@gdavison
skaff: Uses pre-calculated resource name
86034f2
@gdavison
Fixed constants
2681cc7
ewbankkit
ewbankkit approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccELBV2ListenerRuleDataSource_\|TestAccELBV2Listener_basic\|TestAccELBV2ListenerDataSource_basic\|TestAccELBV2ListenerRule_basic' PKG=elbv2 ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/elbv2/... -v -count 1 -parallel 4  -run=TestAccELBV2ListenerRuleDataSource_\|TestAccELBV2Listener_basic\|TestAccELBV2ListenerDataSource_basic\|TestAccELBV2ListenerRule_basic -timeout 360m
2024/10/24 08:13:30 Initializing Terraform AWS Provider...
=== RUN   TestAccELBV2ListenerDataSource_basic
=== PAUSE TestAccELBV2ListenerDataSource_basic
=== RUN   TestAccELBV2ListenerRuleDataSource_tags
=== PAUSE TestAccELBV2ListenerRuleDataSource_tags
=== RUN   TestAccELBV2ListenerRuleDataSource_tags_NullMap
=== PAUSE TestAccELBV2ListenerRuleDataSource_tags_NullMap
=== RUN   TestAccELBV2ListenerRuleDataSource_tags_EmptyMap
=== PAUSE TestAccELBV2ListenerRuleDataSource_tags_EmptyMap
=== RUN   TestAccELBV2ListenerRuleDataSource_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccELBV2ListenerRuleDataSource_tags_DefaultTags_nonOverlapping
=== RUN   TestAccELBV2ListenerRuleDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccELBV2ListenerRuleDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccELBV2ListenerRuleDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccELBV2ListenerRuleDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccELBV2ListenerRuleDataSource_byARN
=== PAUSE TestAccELBV2ListenerRuleDataSource_byARN
=== RUN   TestAccELBV2ListenerRuleDataSource_byListenerAndPriority
=== PAUSE TestAccELBV2ListenerRuleDataSource_byListenerAndPriority
=== RUN   TestAccELBV2ListenerRuleDataSource_actionAuthenticateCognito
=== PAUSE TestAccELBV2ListenerRuleDataSource_actionAuthenticateCognito
=== RUN   TestAccELBV2ListenerRuleDataSource_actionAuthenticateOIDC
=== PAUSE TestAccELBV2ListenerRuleDataSource_actionAuthenticateOIDC
=== RUN   TestAccELBV2ListenerRuleDataSource_actionFixedResponse
=== PAUSE TestAccELBV2ListenerRuleDataSource_actionFixedResponse
=== RUN   TestAccELBV2ListenerRuleDataSource_actionForwardWeightedStickiness
=== PAUSE TestAccELBV2ListenerRuleDataSource_actionForwardWeightedStickiness
=== RUN   TestAccELBV2ListenerRuleDataSource_actionRedirect
=== PAUSE TestAccELBV2ListenerRuleDataSource_actionRedirect
=== RUN   TestAccELBV2ListenerRuleDataSource_conditionHostHeader
=== PAUSE TestAccELBV2ListenerRuleDataSource_conditionHostHeader
=== RUN   TestAccELBV2ListenerRuleDataSource_conditionHTTPHeader
=== PAUSE TestAccELBV2ListenerRuleDataSource_conditionHTTPHeader
=== RUN   TestAccELBV2ListenerRuleDataSource_conditionHTTPRequestMethod
=== PAUSE TestAccELBV2ListenerRuleDataSource_conditionHTTPRequestMethod
=== RUN   TestAccELBV2ListenerRuleDataSource_conditionPathPattern
=== PAUSE TestAccELBV2ListenerRuleDataSource_conditionPathPattern
=== RUN   TestAccELBV2ListenerRuleDataSource_conditionQueryString
=== PAUSE TestAccELBV2ListenerRuleDataSource_conditionQueryString
=== RUN   TestAccELBV2ListenerRuleDataSource_conditionSourceIP
=== PAUSE TestAccELBV2ListenerRuleDataSource_conditionSourceIP
=== RUN   TestAccELBV2ListenerRule_basic
=== PAUSE TestAccELBV2ListenerRule_basic
=== CONT  TestAccELBV2ListenerDataSource_basic
=== CONT  TestAccELBV2ListenerRuleDataSource_actionFixedResponse
=== CONT  TestAccELBV2ListenerRule_basic
=== CONT  TestAccELBV2ListenerRuleDataSource_conditionHTTPRequestMethod
--- PASS: TestAccELBV2ListenerRule_basic (216.73s)
=== CONT  TestAccELBV2ListenerRuleDataSource_conditionQueryString
--- PASS: TestAccELBV2ListenerDataSource_basic (225.08s)
=== CONT  TestAccELBV2ListenerRuleDataSource_conditionSourceIP
--- PASS: TestAccELBV2ListenerRuleDataSource_actionFixedResponse (228.93s)
=== CONT  TestAccELBV2ListenerRuleDataSource_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccELBV2ListenerRuleDataSource_conditionHTTPRequestMethod (229.22s)
=== CONT  TestAccELBV2ListenerRuleDataSource_actionAuthenticateOIDC
--- PASS: TestAccELBV2ListenerRuleDataSource_conditionQueryString (218.89s)
=== CONT  TestAccELBV2ListenerRuleDataSource_actionAuthenticateCognito
--- PASS: TestAccELBV2ListenerRuleDataSource_actionAuthenticateOIDC (217.98s)
=== CONT  TestAccELBV2ListenerRuleDataSource_byListenerAndPriority
--- PASS: TestAccELBV2ListenerRuleDataSource_tags_IgnoreTags_Overlap_ResourceTag (227.31s)
=== CONT  TestAccELBV2ListenerRuleDataSource_byARN
--- PASS: TestAccELBV2ListenerRuleDataSource_conditionSourceIP (258.51s)
=== CONT  TestAccELBV2ListenerRuleDataSource_conditionHostHeader
--- PASS: TestAccELBV2ListenerRuleDataSource_actionAuthenticateCognito (237.61s)
=== CONT  TestAccELBV2ListenerRuleDataSource_conditionHTTPHeader
--- PASS: TestAccELBV2ListenerRuleDataSource_byARN (228.73s)
=== CONT  TestAccELBV2ListenerRuleDataSource_conditionPathPattern
--- PASS: TestAccELBV2ListenerRuleDataSource_byListenerAndPriority (248.13s)
=== CONT  TestAccELBV2ListenerRuleDataSource_tags_EmptyMap
--- PASS: TestAccELBV2ListenerRuleDataSource_conditionHostHeader (228.60s)
=== CONT  TestAccELBV2ListenerRuleDataSource_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccELBV2ListenerRuleDataSource_conditionHTTPHeader (223.22s)
=== CONT  TestAccELBV2ListenerRuleDataSource_tags_DefaultTags_nonOverlapping
--- PASS: TestAccELBV2ListenerRuleDataSource_conditionPathPattern (218.48s)
=== CONT  TestAccELBV2ListenerRuleDataSource_tags_NullMap
--- PASS: TestAccELBV2ListenerRuleDataSource_tags_EmptyMap (234.57s)
=== CONT  TestAccELBV2ListenerRuleDataSource_actionForwardWeightedStickiness
--- PASS: TestAccELBV2ListenerRuleDataSource_tags_IgnoreTags_Overlap_DefaultTag (225.55s)
=== CONT  TestAccELBV2ListenerRuleDataSource_tags
--- PASS: TestAccELBV2ListenerRuleDataSource_tags_NullMap (224.66s)
=== CONT  TestAccELBV2ListenerRuleDataSource_actionRedirect
--- PASS: TestAccELBV2ListenerRuleDataSource_tags_DefaultTags_nonOverlapping (236.76s)
--- PASS: TestAccELBV2ListenerRuleDataSource_tags (234.82s)
--- PASS: TestAccELBV2ListenerRuleDataSource_actionForwardWeightedStickiness (245.58s)
--- PASS: TestAccELBV2ListenerRuleDataSource_actionRedirect (226.87s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	1360.569s

@gdavison gdavison merged commit 49da949 into main Oct 24, 2024
45 checks passed
@gdavison gdavison deleted the f-lb-listener-actions branch October 24, 2024 20:02
@github-actions github-actions bot added this to the v5.74.0 milestone Oct 24, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Oct 24, 2024
Update CHANGELOG.md for #39865
2937219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. provider Pertains to the provider itself, rather than any interaction with AWS. service/elbv2 Issues and PRs that pertain to the elbv2 service. skaff Issues and pull requested related to the skaff tool tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.74.0
Development

Successfully merging this pull request may close these issues.

Incomplete listener rules from data.aws_lb_listener & Data source request - data.aws_lb_listener_rule
2 participants
@gdavison @ewbankkit