Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update aws_networkmanager_core_network_policy_document #39880

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dmaclaury
Copy link

@dmaclaury dmaclaury commented Oct 24, 2024

Description

Updating the documentation for data.aws_networkmanager_core_network_policy_document to remove add_to_network_function_group from the attachment_policies block.

Based on AWS docs and the code for this data resource, add_to_network_function_group should only be available under the action block.

Relations

n/a

References

Code for this data resource

AWS docs for the policy object

Output from Acceptance Testing

I'm do not have the means to run acceptance testing on my own

…to_network_function_group` is only available in the `action` block
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/networkmanager Issues and PRs that pertain to the networkmanager service. needs-triage Waiting for first response or review from a maintainer. labels Oct 24, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @dmaclaury 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@dmaclaury dmaclaury marked this pull request as ready for review October 24, 2024 21:58
@dmaclaury dmaclaury requested a review from a team as a code owner October 24, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. service/networkmanager Issues and PRs that pertain to the networkmanager service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant