Add support for engineValkey in the ValidateFunc

[schroedermatthias-iu]

This MR adds valkey as option in the validation function for the allowed engines.
I also added a testcase with best effort, but unfortunately I cannot really run the test as I have no default subnet in my VPC which would be required by the test.

Relations

Closes #39905

Output from Acceptance Testing

make testacc TESTS=TestAccElastiCacheCluster_Engine_valkey PKG=elasticache
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/elasticache/... -v -count 1 -parallel 20 -run='TestAccElastiCacheCluster_Engine_valkey'  -timeout 360m
2024/10/31 17:49:09 Initializing Terraform AWS Provider...
=== RUN   TestAccElastiCacheCluster_Engine_valkey
=== PAUSE TestAccElastiCacheCluster_Engine_valkey
=== CONT  TestAccElastiCacheCluster_Engine_valkey
    cluster_test.go:130: Step 1/2 error: Error running apply: exit status 1
        
        Error: creating ElastiCache Cache Cluster (tf-acc-test-6418033427746438838): operation error ElastiCache: CreateCacheCluster, https response error StatusCode: 400, RequestID: 42f6496b-2635-4932-824b-206cc9ae2a84, InvalidParameterValue: The account does not have any default subnets.
        
          with aws_elasticache_cluster.test,
          on terraform_plugin_test.tf line 12, in resource "aws_elasticache_cluster" "test":
          12: resource "aws_elasticache_cluster" "test" {
        
--- FAIL: TestAccElastiCacheCluster_Engine_valkey (6.93s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	10.909s
FAIL
make: *** [testacc] Error 1

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @schroedermatthias-iu 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[AdamTylerLynch]

LGTM 🚀

[jar-b]

The newly added test is failing with the following error:

% make testacc PKG=elasticache TESTS=TestAccElastiCacheCluster_Engine_valkey
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/elasticache/... -v -count 1 -parallel 20 -run='TestAccElastiCacheCluster_Engine_valkey'  -timeout 360m
2024/11/13 15:16:19 Initializing Terraform AWS Provider...
=== RUN   TestAccElastiCacheCluster_Engine_valkey
=== PAUSE TestAccElastiCacheCluster_Engine_valkey
=== CONT  TestAccElastiCacheCluster_Engine_valkey
    cluster_test.go:130: Step 1/2 error: Error running apply: exit status 1

        Error: creating ElastiCache Cache Cluster (tf-acc-test-8500160142762672679): operation error ElastiCache: CreateCacheCluster, https response error StatusCode: 400, RequestID: cec82629-78b9-44db-a2b5-e188baad50fa, InvalidParameterValue: This API doesn't support Valkey engine. Please use CreateReplicationGroup API for Valkey cluster creation.

          with aws_elasticache_cluster.test,
          on terraform_plugin_test.tf line 12, in resource "aws_elasticache_cluster" "test":
          12: resource "aws_elasticache_cluster" "test" {

--- FAIL: TestAccElastiCacheCluster_Engine_valkey (5.87s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/elasticache        10.926s

We've shared the results with AWS and they are investigating how to proceed.

[bryantbiggs]

at this time, the CreateCacheCluster API does not support valkey - therefore this change is not valid and can be closed

[schroedermatthias-iu]

@bryantbiggs You're right. CacheCluster is the wrong approach here. CacheCluster would have been the right one. Thanks for pointing this out. I think for the ReplicationGroup, the engine valkey is already allowed in the meantime.

BR
Matthias