Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Gateway: clean up tests to remove unneeded serialization #40122

Merged
merged 8 commits into from
Nov 14, 2024

Conversation

gdavison
Copy link
Contributor

Description

API Gateway tests only need to be serialized when a logging IAM role is needed. Remove unneeded account settings so most tests can be run in parallel.

Reduces runtime of TestAccAPIGateway_serial from 12250.59s to 2618.748s

Output from Acceptance Testing

% make testacc PKG=apigateway TESTS=TestAccAPIGateway_serial

--- PASS: TestAccAPIGateway_serial (2613.75s)
    --- PASS: TestAccAPIGateway_serial/Account (458.44s)
        --- PASS: TestAccAPIGateway_serial/Account/ResetOnDelete_false (53.83s)
        --- PASS: TestAccAPIGateway_serial/Account/ResetOnDelete_true (56.30s)
        --- PASS: TestAccAPIGateway_serial/Account/basic (54.39s)
        --- PASS: TestAccAPIGateway_serial/Account/CloudwatchRoleARN_Value (100.70s)
        --- PASS: TestAccAPIGateway_serial/Account/CloudwatchRoleARN_Empty (62.47s)
        --- PASS: TestAccAPIGateway_serial/Account/FrameworkMigration_Basic (48.80s)
        --- PASS: TestAccAPIGateway_serial/Account/FrameworkMigration_CloudwatchRoleARN (81.95s)
    --- PASS: TestAccAPIGateway_serial/MethodSettings (129.94s)
        --- PASS: TestAccAPIGateway_serial/MethodSettings/Multiple (51.12s)
        --- PASS: TestAccAPIGateway_serial/MethodSettings/LoggingLevel (64.21s)
        --- PASS: TestAccAPIGateway_serial/MethodSettings/disappears (14.61s)
        --- PASS: TestAccAPIGateway_serial/MethodSettings/ThrottlingRateLimit (38.25s)
        --- PASS: TestAccAPIGateway_serial/MethodSettings/ThrottlingRateLimitDisabledByDefault (52.34s)
        --- PASS: TestAccAPIGateway_serial/MethodSettings/UnauthorizedCacheControlHeaderStrategy (95.10s)
        --- PASS: TestAccAPIGateway_serial/MethodSettings/RequireAuthorizationForCacheControl (127.99s)
        --- PASS: TestAccAPIGateway_serial/MethodSettings/basic (171.28s)
        --- PASS: TestAccAPIGateway_serial/MethodSettings/CacheDataEncrypted (209.53s)
        --- PASS: TestAccAPIGateway_serial/MethodSettings/ThrottlingBurstLimitDisabledByDefault (330.55s)
        --- PASS: TestAccAPIGateway_serial/MethodSettings/CacheTTLInSeconds (401.20s)
        --- PASS: TestAccAPIGateway_serial/MethodSettings/MetricsEnabled (417.89s)
        --- PASS: TestAccAPIGateway_serial/MethodSettings/ThrottlingBurstLimit (443.27s)
        --- PASS: TestAccAPIGateway_serial/MethodSettings/DataTraceEnabled (706.47s)
        --- PASS: TestAccAPIGateway_serial/MethodSettings/CachingEnabled (772.52s)
    --- PASS: TestAccAPIGateway_serial/Stage (69.69s)
        --- PASS: TestAccAPIGateway_serial/Stage/AccessLogSettings (69.69s)
        --- PASS: TestAccAPIGateway_serial/Stage/disappears (52.70s)
        --- PASS: TestAccAPIGateway_serial/Stage/basic (124.54s)
        --- PASS: TestAccAPIGateway_serial/Stage/AccessLogSettings_kinesis (157.15s)
        --- PASS: TestAccAPIGateway_serial/Stage/CanarySettings (465.06s)
        --- PASS: TestAccAPIGateway_serial/Stage/disappears_restAPI (665.23s)
        --- PASS: TestAccAPIGateway_serial/Stage/CacheSizeCacheDisabled (797.47s)
        --- PASS: TestAccAPIGateway_serial/Stage/Cache (883.96s)
        --- PASS: TestAccAPIGateway_serial/Stage/tags (0.00s)
            --- PASS: TestAccAPIGateway_serial/Stage/tags/ComputedTag_OnCreate (92.36s)
            --- PASS: TestAccAPIGateway_serial/Stage/tags/DefaultTags_emptyResourceTag (104.30s)
            --- PASS: TestAccAPIGateway_serial/Stage/tags/DefaultTags_nonOverlapping (78.64s)
            --- PASS: TestAccAPIGateway_serial/Stage/tags/DefaultTags_nullOverlappingResourceTag (21.58s)
            --- PASS: TestAccAPIGateway_serial/Stage/tags/DefaultTags_providerOnly (223.18s)
            --- PASS: TestAccAPIGateway_serial/Stage/tags/ComputedTag_OnUpdate_Add (234.49s)
            --- PASS: TestAccAPIGateway_serial/Stage/tags/EmptyTag_OnCreate (216.38s)
            --- PASS: TestAccAPIGateway_serial/Stage/tags/IgnoreTags_Overlap_DefaultTag (322.39s)
            --- PASS: TestAccAPIGateway_serial/Stage/tags/DefaultTags_updateToResourceOnly (426.45s)
            --- PASS: TestAccAPIGateway_serial/Stage/tags/DefaultTags_updateToProviderOnly (497.28s)
            --- PASS: TestAccAPIGateway_serial/Stage/tags/basic (521.08s)
            --- PASS: TestAccAPIGateway_serial/Stage/tags/EmptyTag_OnUpdate_Add (556.00s)
            --- PASS: TestAccAPIGateway_serial/Stage/tags/EmptyTag_OnUpdate_Replace (407.19s)
            --- PASS: TestAccAPIGateway_serial/Stage/tags/AddOnUpdate (624.23s)
            --- PASS: TestAccAPIGateway_serial/Stage/tags/DefaultTags_nullNonOverlappingResourceTag (732.29s)
            --- PASS: TestAccAPIGateway_serial/Stage/tags/ComputedTag_OnUpdate_Replace (828.27s)
            --- PASS: TestAccAPIGateway_serial/Stage/tags/null (622.93s)
            --- PASS: TestAccAPIGateway_serial/Stage/tags/DefaultTags_overlapping (975.27s)
            --- PASS: TestAccAPIGateway_serial/Stage/tags/EmptyMap (898.96s)
            --- PASS: TestAccAPIGateway_serial/Stage/tags/IgnoreTags_Overlap_ResourceTag (994.93s)
        --- PASS: TestAccAPIGateway_serial/Stage/WAF (1183.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigateway	2618.748s

@gdavison gdavison requested a review from a team as a code owner November 14, 2024 01:31
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/apigateway Issues and PRs that pertain to the apigateway service. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Nov 14, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@gdavison gdavison merged commit f412f37 into main Nov 14, 2024
43 checks passed
@gdavison gdavison deleted the td-apigateway-stuff branch November 14, 2024 22:04
@github-actions github-actions bot added this to the v5.77.0 milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/apigateway Issues and PRs that pertain to the apigateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants