Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Help Wanted] Migrate Batch Job Definition to Framework + AutoFlex #40149

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danquack
Copy link
Contributor

Description

Looking to migrate this resource to framework. A lot of the code can be removed with auto flex, and will make migration on #29817 a little easier down the line. I'm currently running into a couple bugs that I am struggling to fix, and would love some assistance on.

  • SDK uses DiffSuppressFunc to do comparison of the container_properties node_properties and ecs_properties. Currently when writing back to state, the sdk will add the empty arrays, so the strings are different.
 new value: .container_properties: was
        cty.StringVal("{\"command\":[\"echo\",\"test\"],\"image\":\"busybox\",\"memory\":128,\"vcpus\":1}"),
        but now
        cty.StringVal("{\"command\":[\"echo\",\"test\"],\"environment\":[],\"image\":\"busybox\",\"memory\":128,\"mountPoints\":[],\"resourceRequirements\":[],\"secrets\":[],\"ulimits\":[],\"vcpus\":1,\"volumes\":[]}").
  • Null to empty. I think this is something to do with a missing upgrade function, but adding the legacy tag on auto flex doesn't seem to resolve it.
.parameters: was null, but now cty.MapValEmpty(cty.String).

Relations

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/batch Issues and PRs that pertain to the batch service. sweeper Pertains to changes to or issues with the sweeper. generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. service/batch Issues and PRs that pertain to the batch service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant