Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/resource/aws_elasticache_cluster: Remove now extraneous plan-time validation checks for node_type #4363

Merged
merged 1 commit into from
Apr 26, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 26, 2018

The code adjustment (#4333) went into the v1.16.0 last minute yesterday -- this PR fixes up the testing from that troublesome validation being removed.

This is to fix these in daily acceptance testing:

=== RUN   TestAccAWSElasticacheCluster_NodeTypeResize_Memcached_Ec2Classic
--- FAIL: TestAccAWSElasticacheCluster_NodeTypeResize_Memcached_Ec2Classic (3.98s)
    testing.go:511: Step 0, expected error:
        
        Error applying: 1 error(s) occurred:
        
        * aws_elasticache_cluster.bar: 1 error(s) occurred:
        
        * aws_elasticache_cluster.bar: Error creating Elasticache: InvalidParameterCombination: Instance type cache.t2.micro can only be created in a VPC.
            status code: 400, request id: a13cbe93-491a-11e8-bcdc-0591db82b7f0
        
        To match:
        
        node_type "cache.t2.micro" can only be created in a VPC

=== RUN   TestAccAWSElasticacheCluster_NodeTypeResize_Redis_Ec2Classic
--- FAIL: TestAccAWSElasticacheCluster_NodeTypeResize_Redis_Ec2Classic (4.23s)
    testing.go:511: Step 0, expected error:
        
        Error applying: 1 error(s) occurred:
        
        * aws_elasticache_cluster.bar: 1 error(s) occurred:
        
        * aws_elasticache_cluster.bar: Error creating Elasticache: InvalidParameterCombination: Instance type cache.t2.micro can only be created in a VPC.
            status code: 400, request id: a13e44d3-491a-11e8-a91b-d344dde8a2b5
        
        To match:
        
        node_type "cache.t2.micro" can only be created in a VPC

Testing

18 tests passed (all tests)
=== RUN   TestAccAWSElasticacheCluster_ReplicationGroupID_InvalidAttributes
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_InvalidAttributes (3.18s)
=== RUN   TestAccAWSElasticacheCluster_NumCacheNodes_Redis_Ec2Classic
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Redis_Ec2Classic (3.43s)
=== RUN   TestAccAWSElasticacheCluster_AZMode_Memcached_Ec2Classic
--- PASS: TestAccAWSElasticacheCluster_AZMode_Memcached_Ec2Classic (442.96s)
=== RUN   TestAccAWSElasticacheCluster_AZMode_Redis_Ec2Classic
--- PASS: TestAccAWSElasticacheCluster_AZMode_Redis_Ec2Classic (461.20s)
=== RUN   TestAccAWSElasticacheCluster_Port_Ec2Classic
--- PASS: TestAccAWSElasticacheCluster_Port_Ec2Classic (503.93s)
=== RUN   TestAccAWSElasticacheCluster_SecurityGroup
--- PASS: TestAccAWSElasticacheCluster_SecurityGroup (529.69s)
=== RUN   TestAccAWSElasticacheCluster_NodeTypeResize_Redis_Ec2Classic
--- PASS: TestAccAWSElasticacheCluster_NodeTypeResize_Redis_Ec2Classic (736.29s)
=== RUN   TestAccAWSElasticacheCluster_Engine_Redis_Ec2Classic
--- PASS: TestAccAWSElasticacheCluster_Engine_Redis_Ec2Classic (773.47s)
=== RUN   TestAccAWSElasticacheCluster_vpc
--- PASS: TestAccAWSElasticacheCluster_vpc (809.31s)
=== RUN   TestAccAWSElasticacheCluster_Engine_Memcached_Ec2Classic
--- PASS: TestAccAWSElasticacheCluster_Engine_Memcached_Ec2Classic (814.83s)
=== RUN   TestAccAWSElasticacheCluster_NodeTypeResize_Memcached_Ec2Classic
--- PASS: TestAccAWSElasticacheCluster_NodeTypeResize_Memcached_Ec2Classic (905.95s)
=== RUN   TestAccAWSElasticacheCluster_ReplicationGroupID_SingleReplica_Ec2Classic
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_SingleReplica_Ec2Classic (1088.30s)
=== RUN   TestAccAWSElasticacheCluster_multiAZInVpc
--- PASS: TestAccAWSElasticacheCluster_multiAZInVpc (1102.29s)
=== RUN   TestAccAWSElasticacheCluster_ReplicationGroupID_MultipleReplica_Ec2Classic
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_MultipleReplica_Ec2Classic (1141.16s)
=== RUN   TestAccAWSElasticacheCluster_EngineVersion_Memcached_Ec2Classic
--- PASS: TestAccAWSElasticacheCluster_EngineVersion_Memcached_Ec2Classic (1235.17s)
=== RUN   TestAccAWSElasticacheCluster_EngineVersion_Redis_Ec2Classic
--- PASS: TestAccAWSElasticacheCluster_EngineVersion_Redis_Ec2Classic (1299.49s)
=== RUN   TestAccAWSElasticacheCluster_decreasingCacheNodes
--- PASS: TestAccAWSElasticacheCluster_decreasingCacheNodes (1362.81s)
=== RUN   TestAccAWSElasticacheCluster_snapshotsWithUpdates
--- PASS: TestAccAWSElasticacheCluster_snapshotsWithUpdates (1601.71s)

@bflad bflad added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/elasticache Issues and PRs that pertain to the elasticache service. labels Apr 26, 2018
@bflad bflad added this to the v1.17.0 milestone Apr 26, 2018
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Apr 26, 2018
@bflad bflad requested a review from a team April 26, 2018 13:26
@bflad bflad merged commit dae9553 into master Apr 26, 2018
@bflad bflad deleted the t-aws_elasticache_cluster-remove-erroneous-tests branch April 26, 2018 15:40
@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/elasticache Issues and PRs that pertain to the elasticache service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants