Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_rds_cluster_instance: Properly handle publicly_accessible updates #5991

Merged
merged 1 commit into from
Sep 26, 2018
Merged

resource/aws_rds_cluster_instance: Properly handle publicly_accessible updates #5991

merged 1 commit into from
Sep 26, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Sep 26, 2018

Fixes #5691
Fixes #2381

Changes proposed in this pull request:

  • Properly pass PubliclyAccessible during resource update

Previously:

--- FAIL: TestAccAWSRDSClusterInstance_PubliclyAccessible (623.05s)
    testing.go:527: Step 2 error: Check failed: Check 2/2 error: aws_rds_cluster_instance.test: Attribute 'publicly_accessible' expected "false", got "true"

Output from acceptance testing:

--- PASS: TestAccAWSRDSClusterInstance_PubliclyAccessible (2268.66s)

@bflad
resource/aws_rds_cluster_instance: Properly handle publicly_accessibl…
3522e59 
…e updates

Previously:

```
--- FAIL: TestAccAWSRDSClusterInstance_PubliclyAccessible (623.05s)
    testing.go:527: Step 2 error: Check failed: Check 2/2 error: aws_rds_cluster_instance.test: Attribute 'publicly_accessible' expected "false", got "true"
```

Now:

```
--- PASS: TestAccAWSRDSClusterInstance_PubliclyAccessible (2268.66s)
```
@bflad bflad added bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service. labels Sep 26, 2018
@bflad bflad requested a review from a team September 26, 2018 14:55
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 26, 2018
@bflad bflad added this to the v1.38.0 milestone Sep 26, 2018
@bflad bflad merged commit e673f33 into master Sep 26, 2018
@bflad bflad deleted the b-aws_rds_cluster_instance-publicly_accessible-update branch September 26, 2018 19:38
bflad added a commit that referenced this pull request Sep 26, 2018
@bflad
Update CHANGELOG for #5991
420017f
@bflad
Copy link
Contributor Author

bflad commented Sep 26, 2018

This has been released in version 1.38.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paddycarver paddycarver paddycarver approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.38.0
2 participants
@bflad @paddycarver