Fix aws_glue_job resource attribute

[teraken0509]

Fixes #7325

Changes proposed in this pull request:

• Add support for pythonshell
• Change allocated_capacity attribute to deprecated
  • Remove Default value of allocated_capacity

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueJob_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSGlueJob_ -timeout 120m
=== RUN   TestAccAWSGlueJob_Basic
=== PAUSE TestAccAWSGlueJob_Basic
=== RUN   TestAccAWSGlueJob_AllocatedCapacity
=== PAUSE TestAccAWSGlueJob_AllocatedCapacity
=== RUN   TestAccAWSGlueJob_Command
=== PAUSE TestAccAWSGlueJob_Command
=== RUN   TestAccAWSGlueJob_DefaultArguments
=== PAUSE TestAccAWSGlueJob_DefaultArguments
=== RUN   TestAccAWSGlueJob_Description
=== PAUSE TestAccAWSGlueJob_Description
=== RUN   TestAccAWSGlueJob_ExecutionProperty
=== PAUSE TestAccAWSGlueJob_ExecutionProperty
=== RUN   TestAccAWSGlueJob_MaxRetries
=== PAUSE TestAccAWSGlueJob_MaxRetries
=== RUN   TestAccAWSGlueJob_Timeout
=== PAUSE TestAccAWSGlueJob_Timeout
=== RUN   TestAccAWSGlueJob_SecurityConfiguration
=== PAUSE TestAccAWSGlueJob_SecurityConfiguration
=== RUN   TestAccAWSGlueJob_PythonShell
=== PAUSE TestAccAWSGlueJob_PythonShell
=== RUN   TestAccAWSGlueJob_MaxCapacity
=== PAUSE TestAccAWSGlueJob_MaxCapacity
=== CONT  TestAccAWSGlueJob_Basic
=== CONT  TestAccAWSGlueJob_MaxRetries
=== CONT  TestAccAWSGlueJob_DefaultArguments
=== CONT  TestAccAWSGlueJob_ExecutionProperty
=== CONT  TestAccAWSGlueJob_Description
=== CONT  TestAccAWSGlueJob_Command
=== CONT  TestAccAWSGlueJob_AllocatedCapacity
=== CONT  TestAccAWSGlueJob_PythonShell
=== CONT  TestAccAWSGlueJob_MaxCapacity
=== CONT  TestAccAWSGlueJob_SecurityConfiguration
=== CONT  TestAccAWSGlueJob_Timeout
--- PASS: TestAccAWSGlueJob_PythonShell (65.13s)
--- PASS: TestAccAWSGlueJob_AllocatedCapacity (65.33s)
--- PASS: TestAccAWSGlueJob_Description (73.43s)
--- PASS: TestAccAWSGlueJob_MaxRetries (75.89s)
--- PASS: TestAccAWSGlueJob_MaxCapacity (80.21s)
--- PASS: TestAccAWSGlueJob_ExecutionProperty (83.05s)
--- PASS: TestAccAWSGlueJob_Basic (88.65s)
--- PASS: TestAccAWSGlueJob_Timeout (94.78s)
--- PASS: TestAccAWSGlueJob_DefaultArguments (104.18s)
--- PASS: TestAccAWSGlueJob_SecurityConfiguration (107.97s)
--- PASS: TestAccAWSGlueJob_Command (161.33s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	161.395s

[ericandrewmeadows]

@kterada0509 - you're a rockstar!! Thanks for getting this done so quick - fingers-crossed it will make 0.12 :).

[himanshu-pro]

Why is this still open..?

[rcislo]

When will it be released?

[ejconlon]

Ping (and thank you to the author and reviewers)! It's not possible to create pythonshell jobs without the max_capacity attribute.

[zentavr]

@bflad - I wonder if anyone from your team can review that?

[nywilken]

@kterada0509 my apologies for the long delay here, and thanks for pushing this change forward. The changes you proposed look good. I left a comment to add the ConflictsWith property for the old and new attributes, and I would also like to ask that you rebase your branch onto the latest master to fix a number of linting issues.

Cheers!

[nywilken]

When deprecating an attribute it is important to add ConflictsWith to the resource schema for both the old and new attributes. More information can be found on our deprecation guide at https://www.terraform.io/docs/extend/best-practices/deprecations.html#renaming-an-optional-attribute

[teraken0509]

@nywilken
Fix to add ConflictsWith.

[teraken0509]

@nywilken
Thanks for review.
I rebased master & rerun the below test.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueJob_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSGlueJob_ -timeout 120m
=== RUN   TestAccAWSGlueJob_Basic
=== PAUSE TestAccAWSGlueJob_Basic
=== RUN   TestAccAWSGlueJob_AllocatedCapacity
=== PAUSE TestAccAWSGlueJob_AllocatedCapacity
=== RUN   TestAccAWSGlueJob_Command
=== PAUSE TestAccAWSGlueJob_Command
=== RUN   TestAccAWSGlueJob_DefaultArguments
=== PAUSE TestAccAWSGlueJob_DefaultArguments
=== RUN   TestAccAWSGlueJob_Description
=== PAUSE TestAccAWSGlueJob_Description
=== RUN   TestAccAWSGlueJob_ExecutionProperty
=== PAUSE TestAccAWSGlueJob_ExecutionProperty
=== RUN   TestAccAWSGlueJob_MaxRetries
=== PAUSE TestAccAWSGlueJob_MaxRetries
=== RUN   TestAccAWSGlueJob_Timeout
=== PAUSE TestAccAWSGlueJob_Timeout
=== RUN   TestAccAWSGlueJob_SecurityConfiguration
=== PAUSE TestAccAWSGlueJob_SecurityConfiguration
=== RUN   TestAccAWSGlueJob_PythonShell
=== PAUSE TestAccAWSGlueJob_PythonShell
=== RUN   TestAccAWSGlueJob_MaxCapacity
=== PAUSE TestAccAWSGlueJob_MaxCapacity
=== CONT  TestAccAWSGlueJob_Basic
=== CONT  TestAccAWSGlueJob_MaxRetries
=== CONT  TestAccAWSGlueJob_PythonShell
=== CONT  TestAccAWSGlueJob_Timeout
=== CONT  TestAccAWSGlueJob_SecurityConfiguration
=== CONT  TestAccAWSGlueJob_ExecutionProperty
=== CONT  TestAccAWSGlueJob_Description
=== CONT  TestAccAWSGlueJob_DefaultArguments
=== CONT  TestAccAWSGlueJob_MaxCapacity
=== CONT  TestAccAWSGlueJob_Command
=== CONT  TestAccAWSGlueJob_AllocatedCapacity
--- PASS: TestAccAWSGlueJob_PythonShell (63.91s)
--- PASS: TestAccAWSGlueJob_AllocatedCapacity (83.88s)
--- PASS: TestAccAWSGlueJob_Command (84.27s)
--- PASS: TestAccAWSGlueJob_MaxRetries (88.36s)
--- PASS: TestAccAWSGlueJob_MaxCapacity (92.48s)
--- PASS: TestAccAWSGlueJob_Description (93.83s)
--- PASS: TestAccAWSGlueJob_DefaultArguments (95.86s)
--- PASS: TestAccAWSGlueJob_SecurityConfiguration (99.02s)
--- PASS: TestAccAWSGlueJob_Timeout (115.07s)
--- PASS: TestAccAWSGlueJob_Basic (150.31s)
--- PASS: TestAccAWSGlueJob_ExecutionProperty (164.13s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	164.223s

[nywilken]

@kterada0509 thanks for the quick updates. This is good to go 👍

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!