Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/resource/aws_msk_cluster: Additional information about bootstrap_brokers and bootstrap_brokers_tls #8957

Merged
merged 2 commits into from
Jun 18, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jun 12, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #8952

Specifying only TLS encryption in transit for client-broker communication was a recent feature addition. Here we update the example and attribute references to account for the cases where the values should be filled in depending on that encryption in transit setting.

Release note for CHANGELOG:

NONE

Output from acceptance testing: N/A documentation update

…_brokers and bootstrap_brokers_tls

Reference: #8952

Specifying only TLS encryption in transit for client-broker communication was a recent feature addition. Here we update the example and attribute references to account for the cases where the values should be filled in depending on that encryption in transit setting.
@bflad bflad added documentation Introduces or discusses updates to documentation. service/kafka Issues and PRs that pertain to the kafka service. labels Jun 12, 2019
@bflad bflad requested a review from a team June 12, 2019 10:07
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Jun 12, 2019
@cdenneen
Copy link

@bflad maybe some mention of which is the default?

@bflad
Copy link
Contributor Author

bflad commented Jun 12, 2019

The existing client_broker argument notes the default that matches the MSK API Reference, however in #8953 (comment) we have observed that the default is inconsistent between AWS regions. Guidance on the default value will likely be informed by that AWS Support Case.

@bflad
Copy link
Contributor Author

bflad commented Jun 13, 2019

Rebased against master.

Copy link
Contributor

@ryndaniels ryndaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bflad bflad added this to the v2.16.0 milestone Jun 18, 2019
@bflad bflad merged commit f8ae819 into master Jun 18, 2019
@bflad bflad deleted the d-aws_msk_cluster-tls branch June 18, 2019 12:32
@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/kafka Issues and PRs that pertain to the kafka service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_msk_cluster - output bootstrap_brokers returns empty
3 participants