Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/ssm_maintenance_window_target: name and description are optional #9165

Merged
merged 1 commit into from
Jun 27, 2019

Commits on Jun 27, 2019

  1. resource/ssm_maintenance_window_target: name and description are

    optional
    
    Fixes: hashicorp#8791
    
    the name ane description fields were optional but we never implemented
    the d.GetOk(fieldName) on them. This just changes that to remove the
    validation errors
    
    The docs and the schema were already correct so this is a very simple
    change
    
    ```
    ▶ acctests aws TestAccAWSSSMMaintenanceWindowTarget_
    === RUN   TestAccAWSSSMMaintenanceWindowTarget_basic
    === PAUSE TestAccAWSSSMMaintenanceWindowTarget_basic
    === RUN   TestAccAWSSSMMaintenanceWindowTarget_noNameOrDescription
    === PAUSE TestAccAWSSSMMaintenanceWindowTarget_noNameOrDescription
    === RUN   TestAccAWSSSMMaintenanceWindowTarget_validation
    === PAUSE TestAccAWSSSMMaintenanceWindowTarget_validation
    === RUN   TestAccAWSSSMMaintenanceWindowTarget_update
    === PAUSE TestAccAWSSSMMaintenanceWindowTarget_update
    === CONT  TestAccAWSSSMMaintenanceWindowTarget_basic
    === CONT  TestAccAWSSSMMaintenanceWindowTarget_update
    === CONT  TestAccAWSSSMMaintenanceWindowTarget_validation
    === CONT  TestAccAWSSSMMaintenanceWindowTarget_noNameOrDescription
    --- PASS: TestAccAWSSSMMaintenanceWindowTarget_validation (4.60s)
    --- PASS: TestAccAWSSSMMaintenanceWindowTarget_noNameOrDescription (34.75s)
    --- PASS: TestAccAWSSSMMaintenanceWindowTarget_basic (34.95s)
    --- PASS: TestAccAWSSSMMaintenanceWindowTarget_update (51.77s)
    PASS
    ok  	github.com/terraform-providers/terraform-provider-aws/aws	51.842s
    ```
    stack72 committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    61de286 View commit details
    Browse the repository at this point in the history