Skip to content

Commit

Permalink
Merge pull request #1371 from hashicorp/bug/synchronization-package-r…
Browse files Browse the repository at this point in the history
…egistration

bugfix: fix incorrect synchronization package registration
  • Loading branch information
manicminer authored May 9, 2024
2 parents 0e6b568 + 82393b0 commit f27c468
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 4 deletions.
5 changes: 4 additions & 1 deletion .github/labeler-issue-triage.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,10 @@ feature/policies:
- '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azuread_(authentication_strength_policy|claims_mapping_policy|group_role_management_policy)((.|\n)*)###'

feature/service-principals:
- '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azuread_(client_config|service_principal|synchronization_)((.|\n)*)###'
- '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azuread_(client_config|service_principal)((.|\n)*)###'

feature/synchronization:
- '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azuread_synchronization_((.|\n)*)###'

feature/user-flows:
- '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azuread_user_flow_attribute((.|\n)*)###'
Expand Down
4 changes: 4 additions & 0 deletions .github/labeler-pull-request-triage.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,10 @@ feature/service-principals:
- changed-files:
- any-glob-to-any-file:
- internal/services/serviceprincipals/**/*

feature/synchronization:
- changed-files:
- any-glob-to-any-file:
- internal/services/synchronization/**/*

feature/user-flows:
Expand Down
1 change: 1 addition & 0 deletions .teamcity/components/generated/services.kt
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ var services = mapOf(
"invitations" to "Invitations",
"policies" to "Policies",
"serviceprincipals" to "Service Principals",
"synchronization" to "Synchronization",
"userflows" to "User Flows",
"users" to "Users"
)
6 changes: 3 additions & 3 deletions internal/services/synchronization/registration.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,18 @@ type Registration struct{}

// Name is the name of this Service
func (r Registration) Name() string {
return "Service Principals"
return "Synchronization"
}

// AssociatedGitHubLabel is the issue/PR label which can be applied to PRs that include changes to this service package
func (r Registration) AssociatedGitHubLabel() string {
return "feature/service-principals"
return "feature/synchronization"
}

// WebsiteCategories returns a list of categories which can be used for the sidebar
func (r Registration) WebsiteCategories() []string {
return []string{
"Service Principals",
"Synchronization",
}
}

Expand Down

0 comments on commit f27c468

Please sign in to comment.