Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Source to get Gets Object IDs or Application IDs for multiple Service Principals i.e. azuread_service_principals #471

Closed
nitmatgeo opened this issue Jun 29, 2021 · 5 comments · Fixed by #555

Comments

@nitmatgeo
Copy link

nitmatgeo commented Jun 29, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritise this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritise the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Similar to azuread_service_principal, we require something new like azuread_service_principals just like we have for azuread_users. This will help to pass list of SPNs and retrieve their Object IDs as a list.

New or Affected Resource(s)

  • azuread_service_principals

@manicminer your views please :) If approved, I think this could be pretty easy for your team if it could be almost replication similar to azuread_users.

@manicminer
Copy link
Contributor

Hi @nitmatgeo, thanks for the feature request. This seems like it would be a reasonable addition. I'm curious to learn more about your use case, if you're able to give a little more detail?

@nitmatgeo
Copy link
Author

nitmatgeo commented Jun 29, 2021

Hey @manicminer really appreciate your support; I am in the process of creating some automation to manage IAM & RBAC in Azure using Terraform by integrating data in CSV files. I am also eagerly awaiting v2.1.0 😸 Currently, I could achieve most of it especially with users & groups.
Only thing am yet to achieve are-

  1. azuread_user: support the mail field #452
  2. Discrete feature to create multiple AAD Group Owners #435
  3. I am planning to extend it to SPN as well; this Data Source to get Gets Object IDs or Application IDs for multiple Service Principals i.e. azuread_service_principals #471 is 1 step towards it.

For instance, one of my objective is that I want to add SPN as a member to a group and my file will have Type specified as SPN or User or Group and based on the type, I create a lookup based on types so as to assign respective objectID as a member to group API. Please let me know if you require further information.

@manicminer
Copy link
Contributor

Thanks for the additional context. That makes sense - I was imagining something where you'd be sourcing an external list of service principals :)

@github-actions
Copy link

This functionality has been released in v2.2.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants