Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax updates for Terraform 0.12, support application_id argument on data.azuread_application #274

Merged
merged 3 commits into from
Jun 18, 2020

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Jun 12, 2020

  • Update documentation examples and acceptance test configs to use Terraform 0.12 style expressions
  • Support the application_id argument for data.azuread_application for locating applications

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one comment (that exactly one of required all properties to be listed) LGTM 👍

azuread/data_application.go Outdated Show resolved Hide resolved
@manicminer
Copy link
Contributor Author

Waiting on #271 to fix the tests before merging.

@manicminer manicminer mentioned this pull request Jun 15, 2020
@ghost
Copy link

ghost commented Jul 9, 2020

This has been released in version 0.11.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 0.11.0"
}
# ... other configuration ...

@manicminer manicminer deleted the update-tf12-style branch July 9, 2020 11:03
@ghost
Copy link

ghost commented Jul 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants