Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azuread_group: support for dynamic_memberships #695

Merged
merged 3 commits into from
Dec 15, 2021
Merged

azuread_group: support for dynamic_memberships #695

merged 3 commits into from
Dec 15, 2021

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Dec 7, 2021 •
edited
Loading

Depends on: manicminer/hamilton#132 (requires rebase prior to merge)

Closes: #132

  • data.azuread_group - support for the dynamic_membership block
  • azuread_group - support for the dynamic_membership block
  • azuread_group - support the DynamicMembership value for the types property

@manicminer manicminer added this to the v2.13.0 milestone Dec 7, 2021
@manicminer manicminer force-pushed the feature/dynamic-group-membership branch from 9848ed1 to 16ff883 Compare December 7, 2021 22:52
@manicminer
Copy link
Contributor Author

Test results

Screenshot 2021-12-07 at 23 00 08

@manicminer manicminer force-pushed the feature/dynamic-group-membership branch from 16ff883 to e34e7af Compare December 8, 2021 12:19
@manicminer manicminer requested a review from a team December 8, 2021 12:19
@manicminer
ommit
b954528 
azuread_group: rename processing_enabled to enabled, add plan-time check for dynamic_membership block
mbfrahry
mbfrahry approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@manicminer
Copy link
Contributor Author

@mbfrahry Thanks!

Updated test results:

Screenshot 2021-12-15 at 22 20 09

@mbfrahry mbfrahry changed the title azuread_group: support for dynamic memberships azuread_group: support for dynamic_memberships Dec 15, 2021
@mbfrahry mbfrahry merged commit ddb392a into main Dec 15, 2021
@mbfrahry mbfrahry deleted the feature/dynamic-group-membership branch December 15, 2021 22:21
mbfrahry added a commit that referenced this pull request Dec 15, 2021
@mbfrahry
Update changelog for #695
b139fc8
@github-actions
Copy link

This functionality has been released in v2.13.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
dependencies enhancement feature/groups size/XL
Projects
None yet
Milestone
v2.13.0
Development

Successfully merging this pull request may close these issues.

Add support for Dynamic Group membership
2 participants
@manicminer @mbfrahry