Deprecate use_server_default based on Azure/azure-rest-api-specs#97…

…62 (comment)
hashicorp · Oct 6, 2021 · 66dbf2a · 66dbf2a
1 parent 7ec6428
commit 66dbf2a
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/internal/services/mssql/mssql_database_resource.go b/internal/services/mssql/mssql_database_resource.go
@@ -282,6 +282,19 @@ func resourceMsSqlDatabase() *pluginsdk.Resource {
 							Optional:     true,
 							ValidateFunc: validation.StringIsNotEmpty,
 						},
+
+						// TODO - 3.0: Remove this property
+						"use_server_default": {
+							Type:             pluginsdk.TypeString,
+							Optional:         true,
+							DiffSuppressFunc: suppress.CaseDifference,
+							Default:          "Disabled",
+							ValidateFunc: validation.StringInSlice([]string{
+								"Disabled",
+								"Enabled",
+							}, true),
+							Deprecated: "This field is now non-functional and thus will be removed in version 3.0 of the Azure Provider",
+						},
 					},
 				},
 			},

diff --git a/internal/services/mssql/mssql_database_resource_test.go b/internal/services/mssql/mssql_database_resource_test.go
@@ -1209,7 +1209,6 @@ resource "azurerm_mssql_database" "test" {
     email_account_admins       = "Enabled"
     storage_account_access_key = azurerm_storage_account.test.primary_access_key
     storage_endpoint           = azurerm_storage_account.test.primary_blob_endpoint
-    use_server_default         = "Disabled"
   }
 
   tags = {

diff --git a/website/docs/r/mssql_database.html.markdown b/website/docs/r/mssql_database.html.markdown
@@ -140,7 +140,6 @@ a `threat_detection_policy` block supports the following:
 * `retention_days` - (Optional) Specifies the number of days to keep in the Threat Detection audit logs.
 * `storage_account_access_key` - (Optional) Specifies the identifier key of the Threat Detection audit storage account. Required if `state` is `Enabled`.
 * `storage_endpoint` - (Optional) Specifies the blob storage endpoint (e.g. https://MyAccount.blob.core.windows.net). This blob storage will hold all Threat Detection audit logs. Required if `state` is `Enabled`.
-* `use_server_default` - (Optional) Should the default server policy be used? Defaults to `Disabled`.
 
 ---