Merge pull request #10216 from jcanizalez/fix_streaming_endpoint

fix error on azurerm_media_streaming_endpoint when destroying a running instance

azurerm/internal/services/media/media_streaming_endpoint_resource.go

@@ -434,6 +434,24 @@ func resourceMediaStreamingEndpointDelete(d *schema.ResourceData, meta interface
 		return err
 	}
 
+	// Stop Streaming Endpoint before we attempt to delete it.
+	resp, err := client.Get(ctx, id.ResourceGroup, id.MediaserviceName, id.Name)
+	if err != nil {
+		return fmt.Errorf("reading %s: %+v", id, err)
+	}
+	if props := resp.StreamingEndpointProperties; props != nil {
+		if props.ResourceState == media.StreamingEndpointResourceStateRunning {
+			stopFuture, err := client.Stop(ctx, id.ResourceGroup, id.MediaserviceName, id.Name)
+			if err != nil {
+				return fmt.Errorf("stopping %s: %+v", id, err)
+			}
+
+			if err = stopFuture.WaitForCompletionRef(ctx, client.Client); err != nil {
+				return fmt.Errorf("waiting for %s to stop: %+v", id, err)
+			}
+		}
+	}
+
 	future, err := client.Delete(ctx, id.ResourceGroup, id.MediaserviceName, id.Name)
 	if err != nil {
 		return fmt.Errorf("Error deleting Streaming Endpoint %q in Media Services Account %q (Resource Group %q): %+v", id.Name, id.MediaserviceName, id.ResourceGroup, err)

azurerm/internal/services/media/media_streaming_endpoint_resource_test.go

@@ -63,6 +63,38 @@ func TestAccMediaStreamingEndpoint_MaxCacheAge(t *testing.T) {
 	})
 }
 
+func TestAccMediaStreamingEndpoint_shouldStopWhenStarted(t *testing.T) {
+	data := acceptance.BuildTestData(t, "azurerm_media_streaming_endpoint", "test")
+	r := MediaStreamingEndpointResource{}
+
+	data.ResourceTest(t, r, []resource.TestStep{
+		{
+			Config: r.basic(data),
+			Check: resource.ComposeAggregateTestCheckFunc(
+				data.CheckWithClient(r.Start),
+			),
+		},
+	})
+}
+
+func (r MediaStreamingEndpointResource) Start(ctx context.Context, client *clients.Client, state *terraform.InstanceState) error {
+	id, err := parse.StreamingEndpointID(state.ID)
+	if err != nil {
+		return err
+	}
+
+	future, err := client.Media.StreamingEndpointsClient.Start(ctx, id.ResourceGroup, id.MediaserviceName, id.Name)
+	if err != nil {
+		return fmt.Errorf("starting %s: %+v", id, err)
+	}
+
+	if err := future.WaitForCompletionRef(ctx, client.Media.StreamingEndpointsClient.Client); err != nil {
+		return fmt.Errorf("waiting for %s to start: %+v", id, err)
+	}
+
+	return nil
+}
+
 func (MediaStreamingEndpointResource) Exists(ctx context.Context, clients *clients.Client, state *terraform.InstanceState) (*bool, error) {
 	id, err := parse.StreamingEndpointID(state.ID)
 	if err != nil {