Skip to content

Commit

Permalink
implement for windows virtual machine
Browse files Browse the repository at this point in the history
  • Loading branch information
ArcturusZhang committed Mar 3, 2021
1 parent 9eaa762 commit a95d747
Showing 1 changed file with 13 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,14 @@ func resourceWindowsVirtualMachine() *schema.Resource {
ValidateFunc: computeValidate.VirtualMachineScaleSetID,
},

"platform_fault_domain": {
Type: schema.TypeInt,
Optional: true,
ForceNew: true,
RequiredWith: []string{"virtual_machine_scale_set_id"},

This comment has been minimized.

Copy link
@marcusmills

marcusmills Jul 2, 2021

@ArcturusZhang Why is the scale set ID required with platform_fault_domain, we use availability sets and not scale sets?

This comment has been minimized.

Copy link
@ArcturusZhang

ArcturusZhang Jul 5, 2021

Author Contributor

This field was initially designed to be used accompany with the VMSS Flexible to assign a specific fault domain.
I am not sure if you should use the platform_fault_domain_count?

ValidateFunc: validation.IntAtLeast(0),
},

"winrm_listener": winRmListenerSchema(),

"zone": {
Expand Down Expand Up @@ -515,6 +523,10 @@ func resourceWindowsVirtualMachineCreate(d *schema.ResourceData, meta interface{
}
}

if v, ok := d.GetOk("platform_fault_domain"); ok {
params.PlatformFaultDomain = utils.Int32(int32(v.(int)))
}

if v, ok := d.GetOk("timezone"); ok {
params.VirtualMachineProperties.OsProfile.WindowsConfiguration.TimeZone = utils.String(v.(string))
}
Expand Down Expand Up @@ -644,6 +656,7 @@ func resourceWindowsVirtualMachineRead(d *schema.ResourceData, meta interface{})
virtualMachineScaleSetId = *props.VirtualMachineScaleSet.ID
}
d.Set("virtual_machine_scale_set_id", virtualMachineScaleSetId)
d.Set("platform_fault_domain", props.PlatformFaultDomain)

if profile := props.OsProfile; profile != nil {
d.Set("admin_username", profile.AdminUsername)
Expand Down

0 comments on commit a95d747

Please sign in to comment.