r/azurerm_app_service: Make key_vault_reference_identity_id configurable #13720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katbyte
changed the title
katbyte
added a commit
that referenced
this pull request
Oct 14, 2021
|
This functionality has been released in v2.81.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
katbyte
pushed a commit
that referenced
this pull request
Nov 2, 2021
…_app` (#13962) This PR adds the key_vault_reference_identity_id attribute for azurerm_function_app. Plus some test cleanup. From the docs: key_vault_reference_identity_id - (Optional) The User Assigned Identity Id used for looking up KeyVault secrets. The identity must be assigned to the application. See Access vaults with a user-assigned identity for more information. Thanks to @patst for #13720. This PR will close #13960 CC: @sebader
katbyte
pushed a commit
that referenced
this pull request
Nov 3, 2021
…ice_slot` (#13988) This PR is related to PR #13720 and #13962 and adds support for key_vault_reference_identity_id to azurerm_app_service_slot. This work is based on @patst's work in PR #13720. === RUN TestAccAppServiceSlot_keyVaultUserAssignedIdentity === PAUSE TestAccAppServiceSlot_keyVaultUserAssignedIdentity === CONT TestAccAppServiceSlot_keyVaultUserAssignedIdentity --- PASS: TestAccAppServiceSlot_keyVaultUserAssignedIdentity (233.09s) PASS ok github.com/hashicorp/terraform-provider-azurerm/internal/services/web 233.130s This PR closes #13968
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #13388 by making the user assigned identity id
for looking up key vault secrets configurable.
The attribute is computed to read the default value (at the moment:
SystemAssigned) if no value is specified .The default value is returned by the API even if no SystemAssigned identity is set for an AppService. Therefore this behaviour should be fine.
Test case succeeded: