Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key_vault_reference_identity_id attribute for azurerm_function_app #13962

Merged
merged 3 commits into from
Nov 2, 2021
Merged

Add key_vault_reference_identity_id attribute for azurerm_function_app #13962

merged 3 commits into from
Nov 2, 2021

Conversation

heoelri
Copy link
Contributor

@heoelri heoelri commented Oct 29, 2021

This PR adds the key_vault_reference_identity_id attribute for azurerm_function_app. Plus some test cleanup.

From the docs:

key_vault_reference_identity_id - (Optional) The User Assigned Identity Id used for looking up KeyVault secrets. The identity must be assigned to the application. See Access vaults with a user-assigned identity for more information.

Thanks to @patst for #13720. This PR will close #13960

CC: @sebader

@heoelri
Copy link
Contributor Author

heoelri commented Oct 29, 2021

make acctests SERVICE='web' TESTARGS='-run=TestAccFunctionApp_keyVaultUserAssignedIdentity' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/web -run=TestAccFunctionApp_keyVaultUserAssignedIdentity -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccFunctionApp_keyVaultUserAssignedIdentity
=== PAUSE TestAccFunctionApp_keyVaultUserAssignedIdentity
=== CONT  TestAccFunctionApp_keyVaultUserAssignedIdentity
--- PASS: TestAccFunctionApp_keyVaultUserAssignedIdentity (232.65s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/web   232.801s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @heoelri - LGTM 🏗️

@katbyte katbyte merged commit b45d14b into hashicorp:main Nov 2, 2021
katbyte added a commit that referenced this pull request Nov 2, 2021
@heoelri heoelri deleted the issue/13960 branch November 3, 2021 07:04
katbyte pushed a commit that referenced this pull request Nov 3, 2021
…ice_slot` (#13988)

This PR is related to PR #13720 and #13962 and adds support for key_vault_reference_identity_id to azurerm_app_service_slot. This work is based on @patst's work in PR #13720.

=== RUN   TestAccAppServiceSlot_keyVaultUserAssignedIdentity
=== PAUSE TestAccAppServiceSlot_keyVaultUserAssignedIdentity
=== CONT  TestAccAppServiceSlot_keyVaultUserAssignedIdentity
--- PASS: TestAccAppServiceSlot_keyVaultUserAssignedIdentity (233.09s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/web   233.130s
This PR closes #13968
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

This functionality has been released in v2.84.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Dec 6, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for configuration of keyVaultReferenceIdentity in azurerm_function_app
2 participants