Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for azurerm_mysql_flexible_server_configuration #13824

Closed
kingsleyadam opened this issue Oct 21, 2021 · 6 comments · Fixed by #13831
Closed

Support for azurerm_mysql_flexible_server_configuration #13824

kingsleyadam opened this issue Oct 21, 2021 · 6 comments · Fixed by #13831

Comments

@kingsleyadam
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

azurerm_mysql_flexible_server was added in #13678 but support for adjusting MySQL Server Paramaters was not included. With the azurerm_mysql_server resource we can do this with the azurerm_mysql_configuration resource.

Request to add a new resource azurerm_mysql_flexible_server_configuration to support MySQL Server Paramater configuration on azurerm_mysql_flexible_server

New or Affected Resource(s)

  • azurerm_mysql_flexible_server_configuration

Potential Terraform Configuration

resource "azurerm_mysql_flexible_server_configuration" "example" {
  name                = "interactive_timeout"
  resource_group_name = azurerm_resource_group.example.name
  server_name         = azurerm_mysql_flexible_server.example.name
  value               = "600"
}

References

@aristosvo
Copy link
Collaborator

@kingsleyadam Do you want to pick this up yourselves or should I give it a try? At first sight this seems like almost copy-past of azurerm_mysql_configuration

@kingsleyadam
Copy link
Author

As much as I would like to @aristosvo, I've never worked in Go, and getting myself up-to-speed would take much longer with my current capacity. Would be great if you could give it a try, I'll check out the PR so I can see what was needed, which should help me learn more about the project structure and Go.

Thanks!

@aristosvo
Copy link
Collaborator

@kingsleyadam No problem, PR is submitted!

I made my commits a bit smaller to make understanding of the functionality and code easier. Let me know if there are any questions 👍

@kingsleyadam
Copy link
Author

Wow, that was quick. I'll take a look. Thanks!

katbyte pushed a commit that referenced this issue Oct 21, 2021
…t configuration on `mysql_flexible_server` (#13831)

Fixes #13824

Functionality, docs and code is 99% copy of azurerm_mysql_configuration but for azurerm_mysql_flexible_server instead of azurerm_mysql_server.
@katbyte katbyte added this to the v2.82.0 milestone Oct 21, 2021
@github-actions
Copy link

This functionality has been released in v2.82.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants