Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synapse Linked Services in Azure Government is not supported. #17362

Closed
1 task done
stonenw opened this issue Jun 23, 2022 · 7 comments · Fixed by #18716
Closed
1 task done

Synapse Linked Services in Azure Government is not supported. #17362

stonenw opened this issue Jun 23, 2022 · 7 comments · Fixed by #18716

Comments

@stonenw
Copy link

stonenw commented Jun 23, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

1.2.3

AzureRM Provider Version

3.10.0

Affected Resource(s)/Data Source(s)

azurerm_synapse_linked_service

Terraform Configuration Files

provider "azurerm" {
    environment = "usgovernment"
    features {}
}
data "azurerm_resource_group" "example" {
  name     = "example"
}

resource "azurerm_storage_account" "example" {
  name                     = "examplestorageacc"
  resource_group_name      = data.azurerm_resource_group.example.name
  location                 = data.azurerm_resource_group.example.location
  account_tier             = "Standard"
  account_replication_type = "LRS"
  account_kind             = "StorageV2"
  is_hns_enabled           = "true"
}

resource "azurerm_storage_data_lake_gen2_filesystem" "example" {
  name               = "example"
  storage_account_id = azurerm_storage_account.example.id

  properties = {
    hello = "aGVsbG8="
  }
}

resource "azurerm_synapse_workspace" "example" {
  name                                 = "example"
  resource_group_name                  = data.azurerm_resource_group.example.name
  location                             = data.azurerm_resource_group.example.location
  storage_data_lake_gen2_filesystem_id = azurerm_storage_data_lake_gen2_filesystem.example.id
  sql_administrator_login              = "sqladminuser"
  sql_administrator_login_password     = "H@Sh1CoR3!"

  aad_admin {
    login     = "XX"
    object_id = "XX"
    tenant_id = "XX"
  }

  identity {
    type = "SystemAssigned"
  }

  tags = {
    Env = "production"
  }
}

resource "azurerm_synapse_linked_service" "example" {
  name                 = "example"
  synapse_workspace_id = azurerm_synapse_workspace.example.id
  type                 = "AzureBlobStorage"
  type_properties_json = <<JSON
{
  "connectionString": "${azurerm_storage_account.example.primary_connection_string}"
}
JSON

}

Debug Output/Panic Output

unavailable.

Expected Behaviour

A Synapse Workspace External connections, Linked services AzureBlobStorage would be created in the newly created Synapse Workspace.

Actual Behaviour

│ Error: Synapse is not supported in this Azure Environment

│ with azurerm_synapse_linked_service.example,
│ on main.tf line 58, in resource "azurerm_synapse_linked_service" "example":
│ 58: resource "azurerm_synapse_linked_service" "example" {

Steps to Reproduce

Using the code provided plus a few naming changes I ran terraform init, then terraform apply to get the errors.

Important Factoids

I am trying to run this in Azure Government.

References

Terraform info:
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/synapse_linked_service

Azure Synapse Workspace Availability in US Government:
https://azure.microsoft.com/en-us/global-infrastructure/services/?rar=true&regions=non-regional,usgov-non-regional,us-dod-central,us-dod-east,usgov-arizona,usgov-texas,usgov-virginia&products=synapse-analytics

@stonenw stonenw added the bug label Jun 23, 2022
@github-actions github-actions bot removed the bug label Jun 23, 2022
@tombuildsstuff tombuildsstuff added the upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR label Jun 24, 2022
@tombuildsstuff
Copy link
Contributor

Looks like support for this was added to the Azure SDK's base layer in this PR as such this should just be upgrading Go-AutoRest.

@tombuildsstuff tombuildsstuff added upstream dependencies good first issue service/synapse and removed upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR upstream labels Jun 24, 2022
@stonenw
Copy link
Author

stonenw commented Jun 24, 2022

Sorry for the ignorance here, but I have no idea how to do that. I have updated the Terraform executable, I have the newest Azure CLI and to my knowledge I've not done anything with Go-AutoRest. I can't seem to find any instructions that make sense to me for upgrading Go-AutoRest short of installing stuff that I don't currently have on my system.
I appreciate the help.

@tombuildsstuff
Copy link
Contributor

@stonenw this is a change which needs to be made to the provider codebase itself, unfortunately this isn't something you can fix in regular Terraform code - the comment above is to save whoever looks into this a bit of time :)

@rohrerb
Copy link
Contributor

rohrerb commented Sep 26, 2022

@tombuildsstuff any update on when usgov will be fixed?

I am seeing this error both of these resources azurerm_synapse_linked_service and azurerm_synapse_managed_private_endpoint

@rohrerb
Copy link
Contributor

rohrerb commented Sep 30, 2022

@tombuildsstuff once the PR is approved for hamilton, could we proceed with the fixes needed for synapse gov?

manicminer/hamilton#186

@github-actions
Copy link

This functionality has been released in v3.27.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants