Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "Custom Header Settings" field for Traffic Manager Endpoint #2187

Closed
izpavlovich opened this issue Oct 30, 2018 · 6 comments · Fixed by #5923
Closed

Support "Custom Header Settings" field for Traffic Manager Endpoint #2187

izpavlovich opened this issue Oct 30, 2018 · 6 comments · Fixed by #5923

Comments

@izpavlovich
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Recently Azure implemented support for adding custom headers to automatically for Traffic Manager endpoint. This functionally is currently missing from the provider

New or Affected Resource(s)

Traffic Manager Endpoint

  • azurerm_resource_arm_traffic_manager_endpoint
@sinvalmendes

This comment has been minimized.

@leonfs
Copy link
Contributor

leonfs commented Feb 4, 2019

The latest Traffic Manager models for the Azure SDK support custom headers.

https://github.com/Azure/azure-sdk-for-go/blob/master/services/trafficmanager/mgmt/2018-03-01/trafficmanager/models.go#L521

@kikyomits
Copy link

Thank you for raising this up. Yes, we definitely need this functionality.
Here is our use case.

[Use Case]
We have OpenShift Cluster, which is RedHat supported Kubernetes Cluster solution, on Azure.
Our OpenShift router, which is L7 load balancer in front of PODs, resolve request endpoint by HOSTNAME, which means that all requests to OpenShift are same IP but different hostnames.
To check our application in the cluster we definitely need to resolve health check coming from Traffic Manager by hostname.

I really hope to configure Custom Header Settings by Terraform

@YashwanthMannem
Copy link

When can we expect "custom header settings" attribute on the "azurerm_traffic_manager_profile" and "azurerm_traffic_manager_endpoint" terraform resources?
Also, I have noticed that "azurerm_traffic_manager_profile" terraform resource does not contain the following attributes "Expected Status Code Ranges", "Probing Interval", "Tolerated Number of Failures", "Probe Timeout"

@ghost
Copy link

ghost commented Mar 27, 2020

This has been released in version 2.3.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.3.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
7 participants