Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Iot Hub consumer groups #2230

Closed
peterdn opened this issue Nov 4, 2018 · 1 comment
Closed

Support for Iot Hub consumer groups #2230

peterdn opened this issue Nov 4, 2018 · 1 comment

Comments

@peterdn
Copy link

peterdn commented Nov 4, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Support is already provided for Event Hub consumer groups (azurerm_eventhub_consumer_group). Although IoT Hubs provide an Event Hub-compatible endpoint for message events, it's not clear that the azurerm_eventhub_consumer_group supports these. I was not able to either create a new consumer group on an IoT Hub, or import an existing one with this resource.

Event Hub consumer groups appear to have IDs [1] of a different form to IoT Hub consumer groups [2].

New or Affected Resource(s)

  • azurerm_eventhub_consumer_group
  • azurerm_iothub
  • (proposed new) azurerm_iothub_consumer_group

Potential Terraform Configuration

resource "azurerm_iothub_consumer_group" "test" {
  name                = "test"
  iothub_name         = "${azurerm_iothub.test.name}"
  resource_group_name = "${azurerm_resource_group.test.name}"
}

References

[1] https://docs.microsoft.com/en-ca/rest/api/eventhub/consumergroups/get
[2] https://docs.microsoft.com/en-ca/rest/api/iothub/iothubresource/geteventhubconsumergroup

@tombuildsstuff tombuildsstuff self-assigned this Nov 4, 2018
tombuildsstuff added a commit that referenced this issue Nov 5, 2018
Tests pass:
```
$ acctests azurerm TestAccAzureRMIotHubConsumerGroup_
=== RUN   TestAccAzureRMIotHubConsumerGroup_events
--- PASS: TestAccAzureRMIotHubConsumerGroup_events (280.43s)
=== RUN   TestAccAzureRMIotHubConsumerGroup_operationsMonitoringEvents
--- PASS: TestAccAzureRMIotHubConsumerGroup_operationsMonitoringEvents (211.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	493.476s
```

Fixes #2230
tombuildsstuff added a commit that referenced this issue Nov 6, 2018
* iothub: refactoring

* New Resource: `azurerm_iothub_consumer_group`

Tests pass:
```
$ acctests azurerm TestAccAzureRMIotHubConsumerGroup_
=== RUN   TestAccAzureRMIotHubConsumerGroup_events
--- PASS: TestAccAzureRMIotHubConsumerGroup_events (280.43s)
=== RUN   TestAccAzureRMIotHubConsumerGroup_operationsMonitoringEvents
--- PASS: TestAccAzureRMIotHubConsumerGroup_operationsMonitoringEvents (211.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	493.476s
```

Fixes #2230

* adding validation for iothub names
Tests pass:

```
=== RUN   TestValidateIoTHubName
--- PASS: TestValidateIoTHubName (0.00s)
=== RUN   TestValidateIoTHubConsumerGroupName
--- PASS: TestValidateIoTHubConsumerGroupName (0.00s)
PASS
```

* fixing the alignment
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants