Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increases name length limit for user_assigned_identity to 128 chars #4094

Conversation

Shenderchuk
Copy link
Contributor

@Shenderchuk Shenderchuk commented Aug 15, 2019

AzureRM provider has hard validation on name string (1,24) for azurerm_user_assigned_identity, Azure increased the name length to 128 chars. Please see #4093

Fixes #4093

@ghost ghost added the size/XS label Aug 15, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @Shenderchuk

@tombuildsstuff tombuildsstuff added this to the v1.33.0 milestone Aug 15, 2019
@tombuildsstuff tombuildsstuff merged commit 87e735d into hashicorp:master Aug 15, 2019
tombuildsstuff added a commit that referenced this pull request Aug 15, 2019
@Shenderchuk Shenderchuk deleted the Updating_UAI_name_limits_from_24_to_128 branch August 19, 2019 07:47
@ghost
Copy link

ghost commented Aug 22, 2019

This has been released in version 1.33.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.33.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 14, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Managed user assigned identities name's limit should be increased to 128 chars
2 participants