Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sampling_percentage In azurerm_application_insights #4487

Closed
SethNute opened this issue Oct 2, 2019 · 3 comments · Fixed by #4925
Closed

Support sampling_percentage In azurerm_application_insights #4487

SethNute opened this issue Oct 2, 2019 · 3 comments · Fixed by #4925

Comments

@SethNute
Copy link

SethNute commented Oct 2, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

This is a feature request for the ability to manage the sampling rate of an application insights resource using the azurerm provider.

It is currently possible to set the sampling percentage using the UI/ARM templates/AZ PowerShell/etc, see the references section below. It would be nice to be able to control it from TF, too.

New or Affected Resource(s)

  • azurerm_application_insights

Potential Terraform Configuration

resource "azurerm_application_insights" "example" {
  name                           = "example"
  location                       = "eastus2"
  resource_group_name            = azurerm_resource_group.example.name
  application_type               = "web"
  sampling_percentage            = var.env == "prod" ? 100 : 25
}

References

Some other ways of creating application insights instances, these all support sampling percentage

@aqche
Copy link
Contributor

aqche commented Nov 20, 2019

Looking into this, will have a PR open soon!

@ghost
Copy link

ghost commented Nov 26, 2019

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants