Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Logic App Resource #610

Closed
scottambroseio opened this issue Dec 7, 2017 · 4 comments · Fixed by #1266
Closed

Feature Request: Logic App Resource #610

scottambroseio opened this issue Dec 7, 2017 · 4 comments · Fixed by #1266
Assignees
@tombuildsstuff
Labels
new-resource service/logic
Milestone
v1.10.0

Comments

@scottambroseio
Copy link

Hi there!

It would be great to see support for Azure Logic Apps (https://azure.microsoft.com/en-gb/services/logic-apps/) via a new resource.
@tombuildsstuff tombuildsstuff mentioned this issue Jan 5, 2018
Merged
@achandmsft achandmsft added M3 and removed enhancement labels Apr 26, 2018
@tombuildsstuff tombuildsstuff added this to the Soon milestone May 10, 2018
tombuildsstuff added a commit that referenced this issue May 21, 2018
@tombuildsstuff
New Resource: azurerm_logic_app_workflow
aed4a32 
Tests pass:

```
$ acctests azurerm TestAccAzureRMLogicAppWorkflow_
=== RUN   TestAccAzureRMLogicAppWorkflow_empty
--- PASS: TestAccAzureRMLogicAppWorkflow_empty (97.38s)
=== RUN   TestAccAzureRMLogicAppWorkflow_tags
--- PASS: TestAccAzureRMLogicAppWorkflow_tags (83.56s)
=== RUN   TestAccAzureRMLogicAppWorkflow_actionHTTP
--- PASS: TestAccAzureRMLogicAppWorkflow_actionHTTP (75.25s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm       256.212s
```

Fixes #610
tombuildsstuff added a commit that referenced this issue May 21, 2018
@tombuildsstuff
New Resource: azurerm_logic_app_workflow
b5f3b03 
Tests pass:

```
$ acctests azurerm TestAccAzureRMLogicAppWorkflow_
=== RUN   TestAccAzureRMLogicAppWorkflow_empty
--- PASS: TestAccAzureRMLogicAppWorkflow_empty (97.38s)
=== RUN   TestAccAzureRMLogicAppWorkflow_tags
--- PASS: TestAccAzureRMLogicAppWorkflow_tags (83.56s)
=== RUN   TestAccAzureRMLogicAppWorkflow_actionHTTP
--- PASS: TestAccAzureRMLogicAppWorkflow_actionHTTP (75.25s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm       256.212s
```

Fixes #610
@tombuildsstuff tombuildsstuff mentioned this issue May 21, 2018
Merged
tombuildsstuff added a commit that referenced this issue May 21, 2018
@tombuildsstuff
New Resource: azurerm_logic_app_workflow
b6b8d44 
Tests pass:

```
$ acctests azurerm TestAccAzureRMLogicAppWorkflow_
=== RUN   TestAccAzureRMLogicAppWorkflow_empty
--- PASS: TestAccAzureRMLogicAppWorkflow_empty (97.38s)
=== RUN   TestAccAzureRMLogicAppWorkflow_tags
--- PASS: TestAccAzureRMLogicAppWorkflow_tags (83.56s)
=== RUN   TestAccAzureRMLogicAppWorkflow_actionHTTP
--- PASS: TestAccAzureRMLogicAppWorkflow_actionHTTP (75.25s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm       256.212s
```

Fixes #610
tombuildsstuff added a commit that referenced this issue Jul 10, 2018
@tombuildsstuff
New Resource: azurerm_logic_app_workflow
3e20424 
Tests pass:

```
$ acctests azurerm TestAccAzureRMLogicAppWorkflow_
=== RUN   TestAccAzureRMLogicAppWorkflow_empty
--- PASS: TestAccAzureRMLogicAppWorkflow_empty (97.38s)
=== RUN   TestAccAzureRMLogicAppWorkflow_tags
--- PASS: TestAccAzureRMLogicAppWorkflow_tags (83.56s)
=== RUN   TestAccAzureRMLogicAppWorkflow_actionHTTP
--- PASS: TestAccAzureRMLogicAppWorkflow_actionHTTP (75.25s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm       256.212s
```

Fixes #610
tombuildsstuff added a commit that referenced this issue Jul 10, 2018
@tombuildsstuff
New Resource: azurerm_logic_app_workflow
70c293c 
Tests pass:

```
$ acctests azurerm TestAccAzureRMLogicAppWorkflow_
=== RUN   TestAccAzureRMLogicAppWorkflow_empty
--- PASS: TestAccAzureRMLogicAppWorkflow_empty (97.38s)
=== RUN   TestAccAzureRMLogicAppWorkflow_tags
--- PASS: TestAccAzureRMLogicAppWorkflow_tags (83.56s)
=== RUN   TestAccAzureRMLogicAppWorkflow_actionHTTP
--- PASS: TestAccAzureRMLogicAppWorkflow_actionHTTP (75.25s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm       256.212s
```

Fixes #610
tombuildsstuff added a commit that referenced this issue Jul 13, 2018
@tombuildsstuff
New Resource: azurerm_logic_app_workflow
aa9062e 
Tests pass:

```
$ acctests azurerm TestAccAzureRMLogicAppWorkflow_
=== RUN   TestAccAzureRMLogicAppWorkflow_empty
--- PASS: TestAccAzureRMLogicAppWorkflow_empty (97.38s)
=== RUN   TestAccAzureRMLogicAppWorkflow_tags
--- PASS: TestAccAzureRMLogicAppWorkflow_tags (83.56s)
=== RUN   TestAccAzureRMLogicAppWorkflow_actionHTTP
--- PASS: TestAccAzureRMLogicAppWorkflow_actionHTTP (75.25s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm       256.212s
```

Fixes #610
@auberryberry
Copy link

Just want to say thank you for this @tombuildsstuff, being able to orchestrate logic apps with terra is a massive win for me!

tombuildsstuff added a commit that referenced this issue Jul 17, 2018
@tombuildsstuff
New Resource: azurerm_logic_app_workflow
4492194 
Tests pass:

```
$ acctests azurerm TestAccAzureRMLogicAppWorkflow_
=== RUN   TestAccAzureRMLogicAppWorkflow_empty
--- PASS: TestAccAzureRMLogicAppWorkflow_empty (97.38s)
=== RUN   TestAccAzureRMLogicAppWorkflow_tags
--- PASS: TestAccAzureRMLogicAppWorkflow_tags (83.56s)
=== RUN   TestAccAzureRMLogicAppWorkflow_actionHTTP
--- PASS: TestAccAzureRMLogicAppWorkflow_actionHTTP (75.25s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm       256.212s
```

Fixes #610
tombuildsstuff added a commit that referenced this issue Jul 17, 2018
@tombuildsstuff
New Resource: azurerm_logic_app_workflow (#1266)
7a6762b 
* Vendoring the Logic App SDK

* New Resource: `azurerm_logic_app_workflow`

Tests pass:

```
$ acctests azurerm TestAccAzureRMLogicAppWorkflow_
=== RUN   TestAccAzureRMLogicAppWorkflow_empty
--- PASS: TestAccAzureRMLogicAppWorkflow_empty (97.38s)
=== RUN   TestAccAzureRMLogicAppWorkflow_tags
--- PASS: TestAccAzureRMLogicAppWorkflow_tags (83.56s)
=== RUN   TestAccAzureRMLogicAppWorkflow_actionHTTP
--- PASS: TestAccAzureRMLogicAppWorkflow_actionHTTP (75.25s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm       256.212s
```

Fixes #610

* Upgrading Logic Apps to v18.0.0 of the Azure SDK for Go

* Moving Actions and Triggers out to separate objects

```
$ acctests azurerm TestAccAzureRMLogicAppWorkflow_
=== RUN   TestAccAzureRMLogicAppWorkflow_importEmpty
--- PASS: TestAccAzureRMLogicAppWorkflow_importEmpty (71.95s)
=== RUN   TestAccAzureRMLogicAppWorkflow_importTags
--- PASS: TestAccAzureRMLogicAppWorkflow_importTags (69.51s)
=== RUN   TestAccAzureRMLogicAppWorkflow_empty
--- PASS: TestAccAzureRMLogicAppWorkflow_empty (66.77s)
=== RUN   TestAccAzureRMLogicAppWorkflow_tags
--- PASS: TestAccAzureRMLogicAppWorkflow_tags (81.51s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	289.789s
```

* New Resource: `azurerm_logic_app_action_http`

Tests pass:
```
$ acctests azurerm TestAccAzureRMLogicAppActionHttp_

=== RUN   TestAccAzureRMLogicAppActionHttp_basic
--- PASS: TestAccAzureRMLogicAppActionHttp_basic (65.75s)
=== RUN   TestAccAzureRMLogicAppActionHttp_headers
--- PASS: TestAccAzureRMLogicAppActionHttp_headers (61.97s)
=== RUN   TestAccAzureRMLogicAppActionHttp_disappears
--- PASS: TestAccAzureRMLogicAppActionHttp_disappears (77.38s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	205.136s
```

* New Resources: `azurerm_logic_app_trigger_http_request` / `azurerm_logic_app_trigger_recurrence`

- Adding documentation for all of the resources
- Making the test check functions more generic

* New Resource: `azurerm_logic_app_action_custom`

* New Resource: `azurerm_logic_app_trigger_custom`

* Adding an example of how to use a logic app

* New Data Source: `azurerm_logic_app_workflow`

```
$ acctests azurerm TestAccDataSourceAzureRMLogicAppWorkflow_
=== RUN   TestAccDataSourceAzureRMLogicAppWorkflow_basic
--- PASS: TestAccDataSourceAzureRMLogicAppWorkflow_basic (69.73s)
=== RUN   TestAccDataSourceAzureRMLogicAppWorkflow_tags
--- PASS: TestAccDataSourceAzureRMLogicAppWorkflow_tags (67.28s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	137.042s
```

* Fixing issues raised during code review

* Adding a customizeDiff for http requests

* Returning an error rather than removing the state
@rifaterdemsahin
Copy link

any updates ?

@tombuildsstuff
Copy link
Contributor

@rifaterdemsahin this shipped in v1.10.0 of the AzureRM Provider: https://www.terraform.io/docs/providers/azurerm/r/logic_app_workflow.html

@tombuildsstuff tombuildsstuff modified the milestones: Soon, 1.10.0 Jul 25, 2018
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tombuildsstuff tombuildsstuff

Labels
new-resource service/logic
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging a pull request may close this issue.

New Resource: azurerm_logic_app_workflow hashicorp/terraform-provider-azurerm
6 participants
@auberryberry @tombuildsstuff @rifaterdemsahin @JunyiYi @scottambroseio @achandmsft