Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for max_surge parameter on azurerm_kubernetes_cluster_node_pool #7892

Closed
jmcshane opened this issue Jul 24, 2020 · 3 comments · Fixed by #10376
Closed

Support for max_surge parameter on azurerm_kubernetes_cluster_node_pool #7892

jmcshane opened this issue Jul 24, 2020 · 3 comments · Fixed by #10376

Comments

@jmcshane
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Support the max surge parameter for upgrading node pools. Available in sdk-for-go in the 2020-04-01 API version here.

New or Affected Resource(s)

  • azurerm_kubernetes_cluster_node_pool

Potential Terraform Configuration

resource "azurerm_kubernetes_cluster_node_pool" "example" {
  name                  = "internal"
  kubernetes_cluster_id = azurerm_kubernetes_cluster.example.id
  vm_size               = "Standard_DS2_v2"
  node_count            = 1
  
  upgrade_settings {
    max_surge = 2
    ## or max_surge = 50%
  }
  tags = {
    Environment = "Production"
  }
}

References

@jmcshane jmcshane changed the title Support for max_surge parameter on azurerm_kubernetes_cluster_node_pool Support for max_surge parameter on azurerm_kubernetes_cluster_node_pool Jul 24, 2020
@shapeofarchitect
Copy link

Can we please , please start to merge these important Pull Requests ?

@ghost
Copy link

ghost commented Feb 18, 2021

This has been released in version 2.48.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.48.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 19, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.