Adding upgrade settings to all kubernetes cluster node pool blocks #8123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcshane
force-pushed
the
feature/node-pool-upgrade-settings
branch
2 times, most recently
from
5fcef6a
to
92f6d78
Compare
jmcshane
force-pushed
the
feature/node-pool-upgrade-settings
branch
from
92f6d78
to
3deec76
Compare
jmcshane
force-pushed
the
feature/node-pool-upgrade-settings
branch
from
3deec76
to
00eb565
Compare
|
Any luck of getting this merged in soon? |
|
@tombuildsstuff / @katbyte: would you be open to a rebased PR? |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7892
Integration test not run yet, let me know the best practice for executing these tests. Structure should match the other tests at this time.
make testpassing locally.The upgrade settings configuration blocks were put into functions in the
kubernetes_cluster_node_pool_resource.gofile. There didn't appear to be an internal/helpers file corresponding to thecontainerservicepackage specifically and so I copied the method structure found in the api management resources.