-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_role_definition crashes when all permissions are empty #9815
Comments
…permissions optional (#9850) * r/role_definition: making the `permissions` block optional The API returns an empty list if an empty permissions block is sent but also allows sending an empty list - so it appears that this isn't required. * r/role_definition: fixing a crash when expanding permissions block Fixes #9815 * r/role_definition: documenting that the `permissions` block is now optional * r/role_definition: splitting out the Update and polling until it's settled down Turns out the Update call is eventually consistent - where a new Role Definition gets created and then reconciled on the backend. This new Role Definition has a new CreatedOn and UpdatedOn, so it's possible to determine when this has been updated - however in testing it can take ~5m for this to settle down. Whilst it's unfortunate this takes a little longer to settle down, this should improve the reliability of resources which depend on this. Unfortunately the Azure SDK doesn't expose these fields in the response, so for now we're using a wrapped to access them and confirm this has been updated. * r/role_definition: fixes #3732 * r/role_definition: tests to private so these are run in sequence * update custompoller for time comparison * missed some test renames * add error handling to time parse * increase timeout and confirmations for consistency checking * go mod vendor Co-authored-by: jackofallops <[email protected]>
This has been released in version 2.53.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.53.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Community Note
Terraform (and AzureRM Provider) Version
Terraform v0.13.3
Affected Resource(s)
azurerm_role_definition
Terraform Configuration Files
Debug Output
Panic Output
Expected Behaviour
Should show valid error message.
Actual Behaviour
Terraform crashes
Steps to Reproduce
terraform apply
Important Factoids
References
The text was updated successfully, but these errors were encountered: