Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_batch_pool: add support for public_address_provisioning_type #10036

Merged
merged 3 commits into from
Jan 4, 2021
Merged

azurerm_batch_pool: add support for public_address_provisioning_type #10036

merged 3 commits into from
Jan 4, 2021

Conversation

favoretti
Copy link
Collaborator

@favoretti favoretti commented Jan 4, 2021

Fixes #10023
Upgrades batch to 2020-03-01

@favoretti favoretti changed the title azurerm_batch_pool: add support for public_address_provision_type azurerm_batch_pool: add support for public_address_provisioning_type Jan 4, 2021
@ghost ghost added the documentation label Jan 4, 2021
@favoretti
Copy link
Collaborator Author

Majority of acceptance tests pass, except the ones that are failing on the quotas for my test sub.

@katbyte katbyte added this to the v2.42.0 milestone Jan 4, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @favoretti - this LGTM 👍

@katbyte katbyte merged commit 39abfdc into hashicorp:master Jan 4, 2021
katbyte added a commit that referenced this pull request Jan 4, 2021
@ghost
Copy link

ghost commented Jan 8, 2021

This has been released in version 2.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.42.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 4, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Azure Batch Pool Public IP address provisioning type
2 participants