-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for blobIndexMatch
in azurerm_storage_management_policy
#10400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yupwei68 -left some comments inline to address before merge
azurerm/internal/services/storage/storage_management_policy_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/storage/storage_management_policy_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/storage/storage_management_policy_resource.go
Outdated
Show resolved
Hide resolved
Thanks @katbyte for your comments. Please continue reviewing. |
azurerm/internal/services/storage/storage_management_policy_resource.go
Outdated
Show resolved
Hide resolved
Thanks for your comments, Tom. Please continue reviewing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yupwei68 - this resource has a bunch of test failures in TC, can we fix them up first?:
TestAccDataSourceStorageManagementPolicy_basic
--
TestAccDataSourceStorageManagementPolicy_blobTypes
TestAccStorageManagementPolicy_basic
TestAccStorageManagementPolicy_blobTypes
TestAccStorageManagementPolicy_multipleRule
TestAccStorageManagementPolicy_singleAction
TestAccStorageManagementPolicy_singleActionUpdate
TestAccStorageManagementPolicy_updateMultipleRule
TestAccStorageManagementPolicy_blobIndexMatch
Thanks kt. All tests have passed. === RUN TestAccStorageManagementPolicy_basic === RUN TestAccDataSourceStorageManagementPolicy_basic |
close for #11163 |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Fix #10399
=== RUN TestAccStorageManagementPolicy_basic
=== PAUSE TestAccStorageManagementPolicy_basic
=== CONT TestAccStorageManagementPolicy_basic
--- PASS: TestAccStorageManagementPolicy_basic (150.54s)
=== RUN TestAccStorageManagementPolicy_singleAction
=== PAUSE TestAccStorageManagementPolicy_singleAction
=== CONT TestAccStorageManagementPolicy_singleAction
--- PASS: TestAccStorageManagementPolicy_singleAction (150.55s)
=== RUN TestAccStorageManagementPolicy_singleActionUpdate
=== PAUSE TestAccStorageManagementPolicy_singleActionUpdate
=== CONT TestAccStorageManagementPolicy_singleActionUpdate
--- PASS: TestAccStorageManagementPolicy_singleActionUpdate (205.12s)
=== RUN TestAccStorageManagementPolicy_multipleRule
=== PAUSE TestAccStorageManagementPolicy_multipleRule
=== CONT TestAccStorageManagementPolicy_multipleRule
--- PASS: TestAccStorageManagementPolicy_multipleRule (150.75s)
=== RUN TestAccStorageManagementPolicy_updateMultipleRule
=== PAUSE TestAccStorageManagementPolicy_updateMultipleRule
=== CONT TestAccStorageManagementPolicy_updateMultipleRule
--- PASS: TestAccStorageManagementPolicy_updateMultipleRule (205.35s)
=== RUN TestAccStorageManagementPolicy_blobTypes
=== PAUSE TestAccStorageManagementPolicy_blobTypes
=== CONT TestAccStorageManagementPolicy_blobTypes
--- PASS: TestAccStorageManagementPolicy_blobTypes (150.79s)
=== RUN TestAccStorageManagementPolicy_blobIndexMatch
=== PAUSE TestAccStorageManagementPolicy_blobIndexMatch
=== CONT TestAccStorageManagementPolicy_blobIndexMatch
--- PASS: TestAccStorageManagementPolicy_blobIndexMatch (305.72s)