Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public_network_access_enabled to azurerm_redis_cache #10410

Merged
merged 3 commits into from
Feb 2, 2021

Conversation

mybayern1974
Copy link
Collaborator

To address issue #9307. Marking this as [WIP] for I'm still running regression acctest under Redis. Once things could pass I would remove the [WIP]. Below paste the run pass result for the newly added test case.

=== RUN   TestAccRedisCache_PublicNetworkAccessDisabledEnabled
=== PAUSE TestAccRedisCache_PublicNetworkAccessDisabledEnabled
=== CONT  TestAccRedisCache_PublicNetworkAccessDisabledEnabled
--- PASS: TestAccRedisCache_PublicNetworkAccessDisabledEnabled (1965.03s)
PASS

Process finished with exit code 0

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one comment this LGTM 👍

website/docs/r/redis_cache.html.markdown Outdated Show resolved Hide resolved
@mybayern1974
Copy link
Collaborator Author

Thank you katbyte for your review. I've updated accordingly.

As for regression acctest, all (totally 28) whose names start with "TestAccRedis..." have passed. So remove the [WIP] from the PR title.

@mybayern1974 mybayern1974 changed the title [WIP] Add public_network_access_enabled to azurerm_redis_cache Add public_network_access_enabled to azurerm_redis_cache Feb 2, 2021
@katbyte katbyte added this to the v2.46.0 milestone Feb 2, 2021
@katbyte katbyte merged commit 0842afc into hashicorp:master Feb 2, 2021
katbyte added a commit that referenced this pull request Feb 2, 2021
@ghost
Copy link

ghost commented Feb 5, 2021

This has been released in version 2.46.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.46.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 4, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants