Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_sql_database: deprecate use_server_default #10628

Merged

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Feb 18, 2021

Per this comment, the useServerDefault in Swagger (i.e. use_server_default in TF) is now deprecated and should be ignored.

This further fixes #7215, #4556.

@manicminer
Copy link
Contributor

Hi @magodo, thanks for continuing to follow this. I agree this resolves #7215 but does it definitely close #4556 (noting this comment about inability to change DTUs)?

@manicminer manicminer added the service/mssql Microsoft SQL Server label Feb 24, 2021
@magodo
Copy link
Collaborator Author

magodo commented Feb 25, 2021

@manicminer I mean the original issue in #4556 is about use_server_default and should be fixed by this PR. Regarding the other problem, I assume it should open another issue to track with?

@katbyte katbyte added this to the v2.49.0 milestone Feb 25, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magodo - aside from 1 comment this LGTM 👍

azurerm/internal/services/sql/sql_database_resource.go Outdated Show resolved Hide resolved
@katbyte katbyte merged commit 873f24b into hashicorp:master Feb 26, 2021
@ghost
Copy link

ghost commented Feb 26, 2021

This has been released in version 2.49.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.49.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terraform plan show state change without code change
3 participants