-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies: upgrade network
to 2020-07-01
#10767
Dependencies: upgrade network
to 2020-07-01
#10767
Conversation
network
to 2020-07-01
network
to 2020-08-01
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 - this'll want manual testing of the network connection monitor and thought about the migration path though, but the latter can be done separately.
Looks like there's a breaking behavioural change for Application Gateway's in this new API version:
|
It seems it's broken in general. |
@tombuildsstuff looks like network package was downgraded to 2020-07-01 in the latest SDK that we're using, should I try that one instead? |
sorry, mistakenly closed it due to slow browser rendering 🤦♀️ - @favoretti, its worth a try but theres no guarantee that version won't have the same issue |
@katbyte np. Minor pain to try. Will give it a shot. |
network
to 2020-08-01
network
to 2020-07-01
@tombuildsstuff @katbyte Looks like |
network
to 2020-07-01
network
to 2020-08-01
Fixes regression introduced in #11270
network
to 2020-08-01
network
to 2020-07-01
This has been released in version 2.58.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.58.0"
}
# ... other configuration ... |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
upgrade
network
to2020-07-01