azurerm_role_assignment - supports "description", "condition", "condition_version"
#10804
Conversation
njuCZ
force-pushed
the
role_assignment_complete
branch
from
541b2e7
to
1a8c08b
Compare
| Type: schema.TypeString, | ||
| Optional: true, | ||
| ForceNew: true, | ||
| }, |
There was a problem hiding this comment.
I have asked the service team, they say it's a new syntax format. It's not easy to write the validation func
There was a problem hiding this comment.
should it at least be no emptry strings?
| Optional: true, | ||
| ForceNew: true, | ||
| ValidateFunc: validation.StringInSlice([]string{ | ||
| "1.0", |
There was a problem hiding this comment.
what does am empty value for this properyt mean?
There was a problem hiding this comment.
condition and condition_version should be both set or unset. When condition_version is empty, it means not set condition and condition_version
There was a problem hiding this comment.
COuld we use RequiredWith to ensure this during plan?
njuCZ
force-pushed
the
role_assignment_complete
branch
from
223b11b
to
0308e41
Compare
|
Could we also ensure all role definition tests pass to ensure the API upgrade isn't breaking anything? i see these two failing: |
|
@katbyte it seems in the new api version, the update api needs more time to become eventually consistency. I have changed the |
|
This has been released in version 2.51.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.51.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
upgrade version for authorization from
2018-09-01-previewto2020-04-01-previewsupport property: "description", "condition", "condition_version"
docs about condition: https://review.docs.microsoft.com/en-us/azure/role-based-access-control/conditions-overview?branch=pr-en-us-119593