Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster: Support for empty_bulk_delete_max in auto_scaler_profile block #11060

Merged
merged 4 commits into from
Apr 20, 2021
Merged

azurerm_kubernetes_cluster: Support for empty_bulk_delete_max in auto_scaler_profile block #11060

merged 4 commits into from
Apr 20, 2021

Conversation

liammoat
Copy link
Contributor

This PR adds support for the max_empty_bulk_delete property in the auto_scaler_profile block for azurerm_kubernetes_cluster.

As per https://docs.microsoft.com/en-us/azure/aks/cluster-autoscaler#using-the-autoscaler-profile

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one comment this looks good @liammoat - once address this should be good to merge!

@njuCZ
Copy link
Contributor

njuCZ commented Apr 14, 2021

@liammoat the tflint reports error because of test file is not formatted, you could install this tool https://github.com/katbyte/terrafmt and execute terrafmt fmt -f path/to/file.

@katbyte katbyte added this to the v2.57.0 milestone Apr 20, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liammoat - LGTM 👍

@katbyte katbyte merged commit 049146d into hashicorp:master Apr 20, 2021
@katbyte katbyte changed the title azurerm_kubernetes_cluster: Support for max_empty_bulk_delete in auto_scaler_profile block azurerm_kubernetes_cluster: Support for empty_bulk_delete_max in auto_scaler_profile block Apr 20, 2021
katbyte added a commit that referenced this pull request Apr 20, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants