-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_hpc_cache
- support for the directory_active_directory, directory_flat_file, directory_ldap blocks
#11332
azurerm_hpc_cache
- support for the directory_active_directory, directory_flat_file, directory_ldap blocks
#11332
Conversation
``` 💤 TF_ACC=1 go test ./azurerm/internal/services/hpccache -v -run="TestAccHPCCache_directory" -timeout=2h 2021/04/13 21:58:10 [DEBUG] not using binary driver name, it's no longer needed 2021/04/13 21:58:10 [DEBUG] not using binary driver name, it's no longer needed === RUN TestAccHPCCache_directoryLDAP === PAUSE TestAccHPCCache_directoryLDAP === RUN TestAccHPCCache_directoryFlatFile === PAUSE TestAccHPCCache_directoryFlatFile === CONT TestAccHPCCache_directoryLDAP === CONT TestAccHPCCache_directoryFlatFile --- PASS: TestAccHPCCache_directoryLDAP (1935.47s) --- PASS: TestAccHPCCache_directoryFlatFile (3257.25s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/hpccache (cached) ```
…_directory_service
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @magodo - given this an initial review with comments left inline
@katbyte Thank you for the review! I've modified the property names per your request. Please take another look! |
azurerm_hpc_cache
- support for kinds of directory settingsazurerm_hpc_cache
- support for the directory_active_directory, directory_flat_file, directory_ldap blocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @magodo - this LGTM 🚀
This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.57.0"
}
# ... other configuration ... |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR add directory settings supports to
azurerm_hpc_cache
, so that the HPC Cache can use an outside source to authenticate users for accessing back-end storage.Reference: https://docs.microsoft.com/en-us/azure/hpc-cache/directory-services
Test Result
LDAP and Flat File
AD
Note that the AD testing is skipped by default, unless the required environments are provided. This is because it is very complicated to setup an AD server automatically, instead we setup it prior to test and pass in the required settings via env var to the testing so that the HPC Cache can be created and connect to that AD server.