Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_iothub - change filter_rule from TypeSet to TypeList #11390

Merged

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Apr 20, 2021

This is to reserve the order of the rules as defined in the TF config.

Fixes: #10341

This is to reserve the order of the rules as defined in the TF config.
@ghost ghost added size/M and removed size/XS labels Apr 20, 2021
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magodo, I've done some testing and it looks like the API ordering is stable for this property. I've expanded the test case a little to try and catch any regressions and re-running now.

@manicminer
Copy link
Contributor

Test result:

Screenshot 2021-04-20 at 17 48 02

@manicminer manicminer added this to the v2.57.0 milestone Apr 20, 2021
@manicminer manicminer merged commit 84b39de into hashicorp:master Apr 21, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IotHub IP filter rule ordering is unpredictable
2 participants