Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add resource azurerm_cosmosdb_notebook_workspace #11536

Merged
merged 2 commits into from
May 6, 2021
Merged

add resource azurerm_cosmosdb_notebook_workspace #11536

merged 2 commits into from
May 6, 2021

Conversation

ms-henglu
Copy link
Contributor

The added tests are listed as follows.

=== RUN   TestAccCosmosDbNotebookWorkspace_basic
=== PAUSE TestAccCosmosDbNotebookWorkspace_basic
=== CONT  TestAccCosmosDbNotebookWorkspace_basic
--- PASS: TestAccCosmosDbNotebookWorkspace_basic (1047.41s)
=== RUN   TestAccCosmosDbNotebookWorkspace_requiresImport
=== PAUSE TestAccCosmosDbNotebookWorkspace_requiresImport
=== CONT  TestAccCosmosDbNotebookWorkspace_requiresImport
--- PASS: TestAccCosmosDbNotebookWorkspace_requiresImport (1024.83s)

katbyte
katbyte requested changes Apr 30, 2021
View reviewed changes
azurerm/internal/services/cosmos/cosmosdb_notebook_workspace_resource.go Outdated
ValidateFunc: validate.CosmosAccountName,
},

"notebook_server_endpoint": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"notebook_server_endpoint": {
"server_endpoint": {

notebook is in the resource name

@ms-henglu
Copy link
Contributor Author

@katbyte hi, I have updated this PR, could you please take another look? Thanks

@ghost ghost removed the waiting-response label May 6, 2021
katbyte
katbyte approved these changes May 6, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-henglu - LGTM 👍

@katbyte katbyte added this to the v2.58.0 milestone May 6, 2021
@katbyte katbyte merged commit ce36cb2 into hashicorp:master May 6, 2021
katbyte added a commit that referenced this pull request May 6, 2021
@katbyte
CHANGELOG.md for #11536
40d92ac
@ghost
Copy link

ghost commented May 7, 2021

This has been released in version 2.58.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.58.0"
}
# ... other configuration ...

favoretti pushed a commit to gro1m/terraform-provider-azurerm that referenced this pull request May 26, 2021
@ms-henglu @favoretti
add resource azurerm_cosmosdb_notebook_workspace (hashicorp#11536)
12dbcf5
favoretti pushed a commit to gro1m/terraform-provider-azurerm that referenced this pull request May 26, 2021
@katbyte @favoretti
CHANGELOG.md for hashicorp#11536
74c3b02
@github-actions
Copy link

github-actions bot commented Jun 7, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation enhancement service/cosmosdb size/XL
Projects
None yet
Milestone
v2.58.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ms-henglu @katbyte