Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler_job: Added storage queue support #1191

Merged
merged 1 commit into from
Jul 9, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented May 2, 2018

No description provided.

@katbyte katbyte added this to the 1.5.0 milestone May 2, 2018
@tombuildsstuff tombuildsstuff modified the milestones: 1.5.0, 1.6.0 May 8, 2018
@tombuildsstuff tombuildsstuff modified the milestones: 1.6.0, 1.7.0 May 24, 2018
@katbyte katbyte modified the milestones: 1.7.0, Soon Jun 12, 2018
@katbyte katbyte force-pushed the f-r-scheduler_job-storage branch 2 times, most recently from 76abbfa to 0c8d5d8 Compare July 7, 2018 07:25
@katbyte katbyte force-pushed the f-r-scheduler_job-storage branch from 0c8d5d8 to 7c774a2 Compare July 7, 2018 08:23
@katbyte katbyte modified the milestones: Soon, 1.9.0 Jul 7, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment but this otherwise LGTM 👍

//sas_token is not returned by the API
if v, ok := d.GetOk(fmt.Sprintf("%s.0.sas_token", blockName)); ok {
block["sas_token"] = v.(string)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be fine to not set this field?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its the same as with web, if i don't pull the value forward there is always a diff:

action_storage_queue.0.sas_token: "" => "$SASTOKEN"

@katbyte katbyte merged commit 0f1ff90 into master Jul 9, 2018
@katbyte
Copy link
Collaborator Author

katbyte commented Jul 9, 2018

builds on #1172

@tombuildsstuff tombuildsstuff deleted the f-r-scheduler_job-storage branch July 10, 2018 06:42
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants