Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_api_management_api_schema - prevent plan not empty after apply for json definitions #12039

Merged
merged 7 commits into from
Jun 17, 2021
Merged

azurerm_api_management_api_schema - prevent plan not empty after apply for json definitions #12039

merged 7 commits into from
Jun 17, 2021

Commits on Jun 17, 2021

  1. Fix schema being always updated 

    * add tests, that verify contents of the schema
* add test for Swagger/OpenAPI based schemas
* add fetching schema definition either from `value` or `definitions` based on
  content type
* add Json supress diff function, that allows ignoring insignificant changes,
  e.g. in white spaces
* use Json supress diff function when the content type is json based
    @wiktorn
    wiktorn committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    59e44dd View commit details
    Browse the repository at this point in the history

  2. Fix schema not always visibile just after creation. 

    Retry client.Get in resourceApiManagementApiSchemaCreateUpdate in case that
schema was not yet created.
    @wiktorn
    wiktorn committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    1fb45e9 View commit details
    Browse the repository at this point in the history

  3. Fix failing unit tests

    @wiktorn
    wiktorn committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    448b077 View commit details
    Browse the repository at this point in the history

  4. Fix linter errors

    @wiktorn
    wiktorn committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    35ea5b1 View commit details
    Browse the repository at this point in the history

  5. Fix switch/case statement

    @wiktorn
    wiktorn committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    027d45b View commit details
    Browse the repository at this point in the history

  6. Keep the old behaviour for unkown content types 

    For unknown content-types use the same logic as for
application/vnd.ms-azure-apim.xsd+xml and others. In case new content types will
appear, there is some chance, that this will be desired behaviour.

If future prove us wrong, then it will be easy to identify place requiring
change due to WARN logging.
    @wiktorn
    wiktorn committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    9a6d400 View commit details
    Browse the repository at this point in the history

  7. Use structure.SuppressJsonDiff

    @wiktorn
    wiktorn committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    835d0e5 View commit details
    Browse the repository at this point in the history