-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_kubernetes_cluster
: Support migration of service_principal
to identity
#12049
azurerm_kubernetes_cluster
: Support migration of service_principal
to identity
#12049
Conversation
azurerm_kubernetes_cluster
: Support migration of service_principal to
identity`azurerm_kubernetes_cluster
: Support migration of service_principal
to identity
@mbfrahry Another AKS upgrade 😄 I hope you don't mind, would you be able to run the whole AccTests suite? I don't have the resources at the moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! I just have some suggestions about presenting the info in the docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This has been released in version 2.63.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.63.0"
}
# ... other configuration ... |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #11288
TO DO
servicePrincipal
tests)Acceptance Tests:
TestAccKubernetesCluster_servicePrincipal
->FAIL because I don't have a secondary principal specified
TestAccKubernetesCluster_servicePrincipalToSystemAssignedIdentity
->PASS
TestAccKubernetesCluster_servicePrincipalToUserAssignedIdentity
->PASS