Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Import support to Redis Cache/Firewall Rule #1211

Merged
merged 7 commits into from
May 13, 2018
Merged

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented May 7, 2018

This was a feature request that came up IRL at Microsoft Build

This also makes the maxclients field Computed, since it's not set-able anymore; and adds a note about the storage connection string bug in Azure/azure-rest-api-specs#3037

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor Author

Tests pass:

screen shot 2018-05-11 at 10 50 12

@tombuildsstuff tombuildsstuff merged commit 95a820c into master May 13, 2018
@tombuildsstuff tombuildsstuff deleted the redis-import branch May 13, 2018 15:28
tombuildsstuff added a commit that referenced this pull request May 13, 2018
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants