Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the NIC/Subnet tests #122

Merged
merged 4 commits into from
Jun 22, 2017
Merged

Fixing the NIC/Subnet tests #122

merged 4 commits into from
Jun 22, 2017

Conversation

tombuildsstuff
Copy link
Contributor

Fixes some broken tests identified in the nightly run. Tests pass:

$ TF_ACC=1 envchain azurerm go test ./azurerm -v -run TestAccAzureRMSubnet_bug7986 -timeout 300m -parallel 5
=== RUN   TestAccAzureRMSubnet_bug7986
--- PASS: TestAccAzureRMSubnet_bug7986 (103.22s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	103.248s

$ TF_ACC=1 envchain azurerm go test ./azurerm -v -run TestAccAzureRMNetworkInterface -timeout 300m -parallel 5
=== RUN   TestAccAzureRMNetworkInterface_importBasic
--- PASS: TestAccAzureRMNetworkInterface_importBasic (117.97s)
=== RUN   TestAccAzureRMNetworkInterface_importIPForwarding
--- PASS: TestAccAzureRMNetworkInterface_importIPForwarding (118.17s)
=== RUN   TestAccAzureRMNetworkInterface_importWithTags
--- PASS: TestAccAzureRMNetworkInterface_importWithTags (102.32s)
=== RUN   TestAccAzureRMNetworkInterface_importMultipleLoadBalancers
--- PASS: TestAccAzureRMNetworkInterface_importMultipleLoadBalancers (156.95s)
=== RUN   TestAccAzureRMNetworkInterface_basic
--- PASS: TestAccAzureRMNetworkInterface_basic (117.07s)
=== RUN   TestAccAzureRMNetworkInterface_disappears
--- PASS: TestAccAzureRMNetworkInterface_disappears (115.30s)
=== RUN   TestAccAzureRMNetworkInterface_enableIPForwarding
--- PASS: TestAccAzureRMNetworkInterface_enableIPForwarding (101.36s)
=== RUN   TestAccAzureRMNetworkInterface_multipleLoadBalancers
--- PASS: TestAccAzureRMNetworkInterface_multipleLoadBalancers (136.90s)
=== RUN   TestAccAzureRMNetworkInterface_withTags
--- PASS: TestAccAzureRMNetworkInterface_withTags (157.60s)
=== RUN   TestAccAzureRMNetworkInterface_bug7986
--- PASS: TestAccAzureRMNetworkInterface_bug7986 (118.27s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	1241.927s

radeksimko
radeksimko approved these changes Jun 22, 2017
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 minor questions, otherwise this LGTM, but take it with a bit of salt given my (lack of) Azure knowledge 😄

azurerm/resource_arm_subnet_test.go
@@ -72,7 +72,7 @@ func TestAccAzureRMSubnet_bug7986(t *testing.T) {
{
Config: initConfig,
Check: resource.ComposeTestCheckFunc(
testCheckAzureRMSubnetExists("azurerm_subnet.test"),
testCheckAzureRMSubnetExists("azurerm_subnet.first"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason not to check the second subnet here too?

azurerm/resource_arm_network_interface_card_test.go
@@ -126,7 +126,7 @@ func TestAccAzureRMNetworkInterface_bug7986(t *testing.T) {
{
Config: testAccAzureRMNetworkInterface_bug7986(rInt),
Check: resource.ComposeTestCheckFunc(
testCheckAzureRMNetworkInterfaceExists("azurerm_network_interface.test"),
testCheckAzureRMNetworkInterfaceExists("azurerm_network_interface.test1"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question - should we check azurerm_network_interface.test2 here as well?

@tombuildsstuff
Copy link
Contributor Author

Updated. Tests still pass:

$ TF_ACC=1 envchain azurerm go test ./azurerm -v -run TestAccAzureRMNetworkInterface_bug7986 -timeout 300m -parallel 5
=== RUN   TestAccAzureRMNetworkInterface_bug7986
--- PASS: TestAccAzureRMNetworkInterface_bug7986 (136.18s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	136.202s

$ TF_ACC=1 envchain azurerm go test ./azurerm -v -run TestAccAzureRMSubnet_bug7986 -timeout 300m -parallel 5
=== RUN   TestAccAzureRMSubnet_bug7986
--- PASS: TestAccAzureRMSubnet_bug7986 (117.32s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	117.333s

@radeksimko
Copy link
Member

LGTM, feel free to merge 😃

@tombuildsstuff tombuildsstuff merged commit df207cb into master Jun 22, 2017
@tombuildsstuff tombuildsstuff deleted the fix-tests branch June 22, 2017 16:22
tombuildsstuff added a commit that referenced this pull request Jun 22, 2017
@tombuildsstuff
Updating to include #122
a53e176
tombuildsstuff added a commit that referenced this pull request Jul 4, 2017
@tombuildsstuff
Merge pull request #122 from terraform-providers/fix-tests
363243e 
Fixing the NIC/Subnet tests
tombuildsstuff added a commit that referenced this pull request Jul 4, 2017
@tombuildsstuff
Updating to include #122
32c367e
@sebastus sebastus mentioned this pull request Jul 12, 2017
Closed
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @radeksimko