Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: azurerm_azuread_application #1269

Merged
merged 5 commits into from
Jul 11, 2018
Merged

New Resource: azurerm_azuread_application #1269

merged 5 commits into from
Jul 11, 2018

Commits on Jul 11, 2018

  1. Add an AD Application provider. 

    Split from PR hashicorp#961.
    @tombuildsstuff
    Xavier Gallardo authored and tombuildsstuff committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    0c827de View commit details
    Browse the repository at this point in the history

  2. Rename resource to azurerm_azuread_application and update function na… 

    …mes to match.
    @tombuildsstuff
    Xavier Gallardo authored and tombuildsstuff committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    0eddb37 View commit details
    Browse the repository at this point in the history

  3. Address code review comments.

    @tombuildsstuff
    Xavier Gallardo authored and tombuildsstuff committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    11d6f1c View commit details
    Browse the repository at this point in the history

  4. Remove Password/Key Credentials to turn them into resources.

    @tombuildsstuff
    Xavier Gallardo authored and tombuildsstuff committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    9e45c65 View commit details
    Browse the repository at this point in the history

  5. Refactoring: 

    - updating the acceptance tests to prefix the name with `acctest` so it's easily identifyable
- wrapping the error messages to display more useful information
- ensuring we disable apps or other tenants before deleting them
- making available_to_other_tenants / oauth2_allow_implicit_flow not computed
- updating the docs

```
 $ acctests azurerm TestAccAzureRMActiveDirectoryApplication_
=== RUN   TestAccAzureRMActiveDirectoryApplication_importBasic
--- PASS: TestAccAzureRMActiveDirectoryApplication_importBasic (38.38s)
=== RUN   TestAccAzureRMActiveDirectoryApplication_importComplete
--- PASS: TestAccAzureRMActiveDirectoryApplication_importComplete (25.42s)
=== RUN   TestAccAzureRMActiveDirectoryApplication_basic
--- PASS: TestAccAzureRMActiveDirectoryApplication_basic (20.18s)
=== RUN   TestAccAzureRMActiveDirectoryApplication_availableToOtherTenants
--- PASS: TestAccAzureRMActiveDirectoryApplication_availableToOtherTenants (21.60s)
=== RUN   TestAccAzureRMActiveDirectoryApplication_complete
--- PASS: TestAccAzureRMActiveDirectoryApplication_complete (20.19s)
=== RUN   TestAccAzureRMActiveDirectoryApplication_update
--- PASS: TestAccAzureRMActiveDirectoryApplication_update (39.92s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	165.735s
```
    @tombuildsstuff
    tombuildsstuff committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    ef6167d View commit details
    Browse the repository at this point in the history